rsync - Apr 2005 - [Bug 2654] New: timeout is always triggered with 2.6.4

https://bugzilla.samba.org/show_bug.cgi?id=2654

           Summary: timeout is always triggered with 2.6.4
           Product: rsync
           Version: 2.6.4
          Platform: All
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: f+samba@congenio.de
         QAContact: rsync-qa@samba.org


When transferring between an rsync 2.6.4 client and daemon giving the
"--timeout" option, the timeout is triggered despite the fact that
data is still
being transferred. This error did not occur with 2.6.3.

I assume this has to do with the check_timeout() routine:

        if (!io_timeout || ignore_timeout)
                return;

        if (!last_io) {
                last_io = time(NULL);
                return;
        }

The new variable (as of 2.6.4) ignore_timeout is changed in generator.c in two
places. I think that this has the ill side-effect that last_io is not modified
any more, so that when ignore_timeout is being reset, the timeout is triggered.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.