rsync - Apr 2005 - [Bug 2645] --one-file-system semantics changed with 2.6.4 (bug?)

https://bugzilla.samba.org/show_bug.cgi?id=2645





------- Additional Comments From dalgoda@ix.netcom.com  2005-04-24 11:36 -------
It looks like the culprit is the change for receiver.c 1.130.  It pulled the
call to send_file_list(-1,...), which is what handled the one_file_system code.

It's not like we can easily go back either, since flist.c 1.267 removed
support
for f=-1.

Bummer.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2645





------- Additional Comments From dalgoda@ix.netcom.com  2005-04-24 14:27 -------
Spent more time looking at this.

It looks like generator.c:delete_in_dir() does check one_file_system initialize
filesystem_dev appropriately.

However, nothing uses it until delete_item() calls get_dirlist().

So, this explains why pre2 and later stop after a couple of directories down.

With some additional instrumentation we see:

delete_in_dir(a/b)
[generator] make_file(a/b/lost+found,*,2)
[generator] make_file(a/b/e,*,2)
[generator] make_file(a/b/f,*,2)
[generator] i=0 0 a/b/e/ mode=040755 len=1024 uid=0 gid=0 flags=4
[generator] i=1 0 a/b/f/ mode=040755 len=1024 uid=0 gid=0 flags=4
[generator] i=2 0 a/b/lost+found/ mode=040700 len=12288 uid=0 gid=0 flags=4
deleting a/b/lost+found/
[generator] make_file(a/b/f/i,*,2)
[generator] make_file(a/b/f/j,*,2)
[generator] i=0 0 a/b/f/i mode=0100644 len=0 uid=0 gid=0 flags=0
[generator] i=1 0 a/b/f/j mode=0100644 len=0 uid=0 gid=0 flags=0
deleting a/b/f/j
deleting a/b/f/i
deleting a/b/f/
[generator] make_file(a/b/e/g,*,2)
[generator] make_file(a/b/e/h,*,2)
[generator] make_file(a/b/e/k,*,2)
[generator] i=0 0 a/b/e/g mode=0100644 len=0 uid=0 gid=0 flags=0
[generator] i=1 0 a/b/e/h mode=0100644 len=0 uid=0 gid=0 flags=0
[generator] i=2 0 a/b/e/k/ mode=040755 len=1024 uid=0 gid=0 flags=4
MOUNT_POINT(k)

But of course, we know b is the real mount point.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2645





------- Additional Comments From dalgoda@ix.netcom.com  2005-04-24 14:51 -------
Created an attachment (id=1169)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1169&action=view)
Fix problem where receiver was not properly handling --one-file-system


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2645


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2005-04-24 15:36 -------
Thanks for your help!  I've checked in a fix based on your suggested patch.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.