John E. Malmberg
2005-Apr-10 02:40 UTC
Can not build with out support for hard or symbolic links.
The file RSYNC.H always defines the macros SUPPORT_LINKS and SUPPORT_HARD_LINKS. #define SUPPORT_LINKS HAVE_READLINK #define SUPPORT_HARD_LINKS HAVE_LINK Everywhere that RSYNC uses SUPPORT_LINKS and SUPPORT_HARD_LINKS it is testing if the macros are defined, not what their values are. This results that the code will always be built with support for hard and symbolic links. -John wb8tyw@qsl.net Personal Opinion Only
Wayne Davison
2005-Apr-10 06:25 UTC
Can not build with out support for hard or symbolic links.
On Sat, Apr 09, 2005 at 10:39:13PM -0400, John E. Malmberg wrote:> Everywhere that RSYNC uses SUPPORT_LINKS and SUPPORT_HARD_LINKS it is > testing if the macros are defined, not what their values are.Thanks for pointing that out. Attached is the fix I just checked into CVS. ..wayne.. -------------- next part -------------- --- rsync.h 28 Mar 2005 17:08:47 -0000 1.261 +++ rsync.h 10 Apr 2005 06:21:23 -0000 @@ -675,8 +675,12 @@ extern char *sys_errlist[]; extern int errno; #endif -#define SUPPORT_LINKS HAVE_READLINK -#define SUPPORT_HARD_LINKS HAVE_LINK +#ifdef HAVE_READLINK +#define SUPPORT_LINKS 1 +#endif +#ifdef HAVE_LINK +#define SUPPORT_HARD_LINKS 1 +#endif #define SIGNAL_CAST (RETSIGTYPE (*)())