rsync - Sep 2004 - [cygwin] Fwd: Updated: rsync-2.6.2-3

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here goes the announcement of the 2.6.2-3 package for cygwin (available
from cygwin's setup itself).

If you wonder what "2.6.2-3" means, it's basically the third
"cygwin
package" that uses rsync-2.6.2 sources.
This third attempt solves both the august security fix and the textmode
bug that 2.6.2-2 had.

follows the original announcement of the cygwin package (only change I
removed the cygwin-ML unsubscribe info as it's not peritent here)

- -------- Original Message --------
Subject: Updated: rsync-2.6.2-3
Date: Tue, 28 Sep 2004 17:31:14 +0200
From: Lapo Luchini <lapo@lapo.it>
Reply-To: The Cygwin Mailing List <cygwin@cygwin.com>
Newsgroups: gmane.os.cygwin.announce
Followup-To: gmane.os.cygwin

Version 2.6.2-3 of the open source utility that provides
fast incremental file transfer has been uploaded.

If you're not sure what version do you have you can use the following
command (if you don't have grep omit the last part):
$ cygcheck -cd rsync
rsync                2.6.2-2

Version 2.6.2-3 is basically the same as 2.6.2-2, but it solves the
textmode issue that did "corrupt" many binary files out there.
(I'm still wondering why that bug didn't show in earlier versions, given
the fact that it was there since the beginning)

Many thanks goes to Sjoerd Mullender for finding (and fixing) the bug
while I was still lingering on hot tropical sand 0=)

If you're using 2.6.2-1 or earlier version to avoid the textmode bug,
you're now strongly advised to upgrade to 2.6.2-4, as it contains the
patch to fix august's SECURITY ADVISORY as in:
http://rsync.samba.org/#security_aug04

- --
L a p o   L u c h i n i
l a p o @ l a p o . i t
w w w . l a p o . i t /
http://www.megatokyo.it
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iEYEARECAAYFAkFZ6j8ACgkQaJiCLMjyUvsSkgCguxiCvhE7+2EXJE7+ccW8EpMD
ll4AoNFdGjpbSHphMNht1hLf+ukV5KUk
=snxl
-----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lapo Luchini wrote:
> This third attempt solves both the august security fix and the textmode
> bug that 2.6.2-2 had.
Whoops, I forgot to ask if the patch could be kindly included in the
original source (it follows). I don't think there is any reason not to
ask for "binary mode" on non-Windows hosts, anyway (it's already
done
also in do_open(...), also).
> If you're using 2.6.2-1 or earlier version to avoid the textmode bug,
> you're now strongly advised to upgrade to 2.6.2-4
and by the way.. yes, this was a typo, no 2.6.2-4 version exists nor it
will ever be, it was meant to be "upgrade to 2.6.2-3" (next one will
be
2.6.3-1).

Here comes the patch (with many thanks to Sjoerd Mullender for having
found the long standing bug, that insidiously began to show up only in
last version (I still wonder why it didn't show in earlier build, really)):

diff -urN -x .build -x .inst -x .sinst rsync-2.6.2-orig/syscall.c
rsync-2.6.2/syscall.c
- --- rsync-2.6.2-orig/syscall.c	2004-02-18 23:33:21.000000000 +0100
+++ rsync-2.6.2/syscall.c	2004-09-28 13:05:03.187353800 +0200
@@ -164,6 +164,7 @@
 			errno = errno_save;
 			return -1;
 		}
+		setmode(fd, O_BINARY);
 		return fd;
 	}
 #else

- --
L a p o   L u c h i n i
l a p o @ l a p o . i t
w w w . l a p o . i t /
http://www.megatokyo.it
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iEYEARECAAYFAkFciVsACgkQaJiCLMjyUvskHwCeMX+ftxMRRs8sm/DmfInN5K/s
Z5EAoN+a5cYMUloq56ZkvM4BVROBfpL4
=1TSX
-----END PGP SIGNATURE-----