samba-bugs@samba.org
2004-Sep-07 22:43 UTC
[Bug 1646] --inplace with --backup --backup-dir does not work
https://bugzilla.samba.org/show_bug.cgi?id=1646 wayned@samba.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From wayned@samba.org 2004-09-07 15:23 ------- Yes, this combination of options did not work at all right (rsync updated the file inplace and then moved the file into the backup dir -- ouch!). I've checked in a file that has the generator copy a backup during the checksum generation phase when --inplace was specified with --backup. Then, the code was further improved to use the backup file as the basis file so that the normal --inplace limits on skipping overwritten blocks was not needed. This, as you noted, makes the transfer as efficient as if --inplace was not used. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.