rsync - Jul 2004 - build bug: HLINK.C

In the module HLINK.C, the routine hard_link_check() will not compile 
with the SUPPORT_HARD_LINKS macro defined to be zero.

It appears that the code should be set to return either a zero or a one. 
  I am not sure which.  The example below assumes zero.

-John
wb8tyw@qsl.net
Personal Opinion Only

int hard_link_check(struct file_struct *file, int skip)
{
#if SUPPORT_HARD_LINKS

         if (!hlink_list || !file->link_u.links)
                 return 0;
         if (skip && !(file->flags & FLAG_HLINK_EOL))
                 hlink_list[file->F_HLINDEX] = file->F_NEXT;
         if (hlink_list[file->F_HLINDEX] != file) {
                 if (verbose > 1) {
                         rprintf(FINFO, "\"%s\" is a hard
link\n",
                             f_name(file));
                 }
                 return 1;
         }
#endif
         return 0;
}

On Sun, Jul 11, 2004 at 07:44:54PM -0400, John E. Malmberg
wrote:
> In the module [hlink.c], the routine hard_link_check() will not compile 
> with the SUPPORT_HARD_LINKS macro defined to be zero.
Thanks.  I've checked in your suggested change to CVS (it should return
0 when hard links are not supported).

..wayne..