rsync - Nov 2003 - --link-dest

Why does --link-dest assume -ugp ?

This patch removes those assumptions allowing mortal users to use
--link-dest for back ups.  (I think...  I didn't look at the large
picture.)

Joe


*** generator.c Thu Aug 29 09:44:55 2002
--- ../generator.c      Tue Nov  4 09:12:59 2003
***************
*** 42,47 ****
--- 42,50 ----
  extern int modify_window;
  extern char *compare_dest;
  extern int link_dest;
+ extern int preserve_perms;
+ extern int preserve_uid;
+ extern int preserve_gid;
   
   
  /* choose whether to skip a particular file */
***************
*** 51,63 ****
        if (st->st_size != file->length) {
                return 0;
        }
!       if (link_dest) {
!               if((st->st_mode & ~_S_IFMT) !=  (file->mode &
~_S_IFMT))
{
!                       return 0;
!               }
!               if (st->st_uid != file->uid || st->st_gid !=
file->gid)
{
!                       return 0;
!               }
        }
   
   
--- 54,64 ----
        if (st->st_size != file->length) {
                return 0;
        }
!       if (link_dest
!           && ((preserve_perms && (st->st_mode &
~_S_IFMT) !=
(file->mode & ~_S_IFMT))
!               || (preserve_uid && st->st_uid != file->uid)
!               || (preserve_gid && st->st_gid != file->gid))) {
!               return 0;
        }

On Tue, Nov 04, 2003 at 09:24:34AM -0500, Joe Batt
wrote:
> Why does --link-dest assume -ugp ?
> 
> This patch removes those assumptions allowing mortal users to use
> --link-dest for back ups.  (I think...  I didn't look at the large
> picture.)
It used to assume -ugp because if it didn't then doing
backups with it would alter the ownership and permissions of
existing backup images when making a new image.

This has been changed in CVS so that if -u -g or -p are not
specified then that aspect will not be tested.

-- 
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		jw@pegasys.ws

		Remember Cernan and Schmitt