rsync - Aug 2002 - rsync --partial produces corrupt data on ctrl-c

Hi there,

in partial mode of Rsync in version up to 2.5.5 on Linux an Cygwin a Ctrl-C
during syncing creates a corrupted file.
The partially transfered data (with a dot on first position of the filename)
will be renamed after a ctrl-c occurs (on both
OS) or a window-close (cygwin) to the filename of a fully transfered file
(without the dot), which aren't complete !

To reproduce the error do:

"rsync --vau --partial /tmp/test1/ /tmp/test2/" on Linux (my system
kernel
2.4.18-4GB) with a big file in directory
/tmp/test1/. Press ctrl-c if rsync creates the temporary dot-file and the
temporary-file will be renamed immediatly, but
the file is not completed.

Ralf Schreiber

---
TRILOS IT-Dienstleistungen
Am Rathaus 15
30952 Ronnenberg
Germany
fon 0511 - 21 44 98-63
fax 0511 - 21 44 98-65
http://www.trilos.de

On Wed, 28 Aug 2002, Ralf Schreiber wrote:
> The partially transfered data (with a dot on first position of the
filename)
> will be renamed after a ctrl-c occurs (on both
> OS) or a window-close (cygwin) to the filename of a fully transfered file
> (without the dot), which aren't complete !
Yes, that is the definition of what partial mode does with a partially
transferred file.  The manual recommends the use of the --compare-dest
option to work around this, but that doesn't appear to do the manual
says at all, so it looks like there is either a bug in the handling of
--compare-dest when --partial is enabled, or a bug in the manual.

One thing that the manual doesn't say is what file should be preferred
if there is a matching file in both the compare-dest dir and the real-
dest dir.  This becomes important if we want to use --compare-dest as a
holding zone for partial files since we would need to have the code
prefer the compare-dest file over the real-dest file if we make it put
partially transferred files into the compare-dest dir.  The current code
prefers the real-dest file over the compare-dest file and puts partially
transferred files into the real-dest dir.

Opinions?

..wayne..