That looks good. A couple of points: - You should put your own name in the copyright in the new files, and add the GPL boilerplate from one of the existing files. - You need to check whether the behavior with downlevel clients and servers will be acceptable. - Ideally there would be a unit test just for the chmod parser. - Please document the fields in chmod_struct. - I'm not sure we need a linked list for chmod_struct, but I haven't completely thought it through. I think we can merge something like this in 2.6. Thanks, Scott! -- Martin
I think --chmod can sensibly always be done locally, which will work better when talking to old servers: If sending files, modify the mode before transmission. If receiving files, modify the mode on receipt. Possibly the complexity of doing this twice in the code is not justified, but I think it would be an OK tradeoff. -- Martin
How about setting up a seperate module for each user, with the uid set for that user, and before invoking rsyncd, du "umask 077", and have the users sync in WITHOUT -p (or -a, of course). Will the rsyncd then, as it's not using the source permissions, follow its umask? Tim Conway tim.conway@philips.com 303.682.4917 Philips Semiconductor - Longmont TC 1880 Industrial Circle, Suite D Longmont, CO 80501 Available via SameTime Connect within Philips, n9hmg on AIM perl -e 'print pack(nnnnnnnnnnnn, 19061,29556,8289,28271,29800,25970,8304,25970,27680,26721,25451,25970), ".\n" ' "There are some who call me.... Tim?"