rsync - Apr 2002 - rsync 2.3.2 with --copy-unsafe-links work badly

Hello,

I try use rsync from Debian 2.2 (rsync 2.3.2) to mirror Debian
distribution tree.

in tree is directories

dists/potato/main/binary-all/
dists/potato/main/binary-i386/
pool/

In directory dists/potato/main/binary-i386/ is some files symbolic links
to ../binary-all/ and some links to ../../../../pool/

In mirror I want preserve links to binary-all/ and copy as files links
to pool/. I try use this rsync command:

rsync -a --delete --copy-unsafe-links ftp.debian.cz::/debian/dists/potato/ \
/home/debian/potato

The result of this is, than all files is copied as regular files and
symlinks are not preserved.

I wrote test script (attached) which demonstrate error.

Is this error fixed in rsync 2.5.5? I try look to archive of mailing list,
and do not find any question about --copy-unsafe-links.

If I mirror from rsync server, must be fixed rsync server or rsync client
or both.

Best regards

Vladimir
---------------------------------------------------------------------------
Vladim?r Michl <Vladimir.Michl@hlubocky.del.cz>
Del a.s., Stroj?rensk? 38, ???r nad S?zavou
pobo?ka Olomouck? 355, Hlubo?ky-Mari?nsk? ?dol?
tel: +420 68 5353548, fax: +420 68 5352364
http://hlubocky.del.cz
-------------- next part --------------
#!/bin/sh

function test_symlink () {
	if [ ! -L $1 ]; then
		echo "File $1 is not symlink or not exists";
	fi;
};

function test_regular () {
	if [ ! -f $1 ]; then
		echo "File $1 is not regular file or not exists";
	fi;
};

function test_copy () {
	test_symlink dest/links/file1;
	test_symlink dest/links/file2;
	test_regular dest/links/unsafefile;
};

rm -rf src dest

mkdir -p src/safe
mkdir -p src/unsafe

mkdir src/safe/files
mkdir src/safe/links

touch src/safe/files/file1
touch src/safe/files/file2
touch src/unsafe/unsafefile

ln -s ../files/file1 src/safe/links/
ln -s ../files/file2 src/safe/links/
ln -s ../../unsafe/unsafefile src/safe/links/

#next rsync copy correctly
echo "rsync with relative path";
rsync -a --copy-unsafe-links src/safe/ dest
test_copy;

rm -rf dest
#next rsync copy uncorectly - links are copied as files not as links
echo "rsync with relative2 path";
(cd src; rsync -a --copy-unsafe-links safe/ ../dest)
test_copy;

rm -rf dest
#next rsync copy uncorectly - all links are copied
echo "rsync with absolute path";
rsync -a --copy-unsafe-links `pwd`/src/safe/ dest
test_copy;

Thanks for the report.  I think there is still a problem in 2.5.5, but
I'm not sure if it is working-as-designed or not.  

The problem seems to lie in flist.c, perhaps in the topsrcname
variable.  I'm not quite sure what this does.

I checked in your script as unsafe-links.test.

-- 
Martin

Dave, can you explain to me what exactly unsafe_symlink is meant to
do?  I can see broadly that it's meant to prevent symlinks pointing
out of "the directory being copied", but when not using path= and a
daemon it's not clear what directory that refers to.  

Also, I don't understand this line:
> 	/* find out what our safety margin is */
> 	for (tok=strtok(src,"/"); tok; tok=strtok(NULL,"/")) {
> 		if (strcmp(tok,"..") == 0) {
> 			depth=0;
Why depth=0 rather than depth--?

Thanks,
-- 
Martin