https://github.com/rspec/rspec-core/pull/421 If you look at rcov''s code it''s clear it always use ":", not PATH_SEPARATOR. On windows where PATH_SEPARATOR=; rspec therefore breaks when using rcov (and having more than 1 directory given to the -I flag). Thanks! -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/rspec-users/attachments/20111005/9593cbbc/attachment.html>
David Chelimsky
2011-Oct-05 11:51 UTC
[rspec-users] Could this pull request pls be considered?
On Oct 5, 2011, at 3:46 AM, sundbp wrote:> https://github.com/rspec/rspec-core/pull/421 > > If you look at rcov''s code it''s clear it always use ":", not PATH_SEPARATOR. On windows where PATH_SEPARATOR=; rspec therefore breaks when using rcov (and having more than 1 directory given to the -I flag). > > Thanks!I had already made that fix before the pull request came in. It''ll be part of the 2.7 release (in the next few weeks). Cheers, David
Nicolás Sanguinetti
2011-Oct-05 12:08 UTC
[rspec-users] Could this pull request pls be considered?
Why this instead of changing rcov to use PATH_SEPARATOR instead? On Wed, Oct 5, 2011 at 6:46 AM, sundbp <patrik.sundberg at gmail.com> wrote:> https://github.com/rspec/rspec-core/pull/421 > > If you look at rcov''s code it''s clear it always use ":", not PATH_SEPARATOR. > On windows where PATH_SEPARATOR=; rspec therefore breaks when using rcov > (and having more than 1 directory given to the -I flag). > > Thanks! > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >
David Chelimsky
2011-Oct-05 12:45 UTC
[rspec-users] Could this pull request pls be considered?
On Oct 5, 2011, at 7:08 AM, Nicol?s Sanguinetti wrote:> On Wed, Oct 5, 2011 at 6:46 AM, sundbp <patrik.sundberg at gmail.com> wrote: >> https://github.com/rspec/rspec-core/pull/421 >> >> If you look at rcov''s code it''s clear it always use ":", not PATH_SEPARATOR. >> On windows where PATH_SEPARATOR=; rspec therefore breaks when using rcov >> (and having more than 1 directory given to the -I flag). >> >> Thanks!> Why this instead of changing rcov to use PATH_SEPARATOR instead?Excellent point! I''ve submitted https://github.com/relevance/rcov/issues/83. Please feel free to comment on it. Cheers, David