rspec users - Jun 2007 - Problems translating should_render from 0.8.2 to 1.0.5

<font size="2">I''m working on a large Rails site and we
want to move from RSpec 0.8.2 to the latest and greatest.&nbsp; So we ran
the translator and yet we''re having a lot of trouble translating
should_render.<br><br>I found this on the web:<br><br>We
will NOT be supporting the following in the new syntax:<br>&nbsp;
controller.should_render<br>&nbsp;
controller.should_redirect_to<br><br>You will be able to use
instead:<br>&nbsp; response.should render_template<br>&nbsp;
response.should render_text<br>&nbsp; response.should
redirect_to<br><br>But the problem I have is that render_template
doesn''t have the functionality that we used in lots of our
should_render expectations.&nbsp; A lot of our should renders specify an
action and and a controller, so now the change over is slow (we have to figure
out which file is being rendered instead), but the big problem is that when
testing actions that render a partial (mostly for ajax calls) we need to test
the locals that get passed into the template.<br><br>here''s
a typical spec:<br>&nbsp; specify "the :start_date should equal
the date passed in" do<br>&nbsp;&nbsp;&nbsp;
@mock_event_calendar_data = mock(''Mock
event_calendar_data'')<br>&nbsp;&nbsp;&nbsp;
EventCalendarData.should_receive(:new).and_return(@mock_event_calendar_data)<br>&nbsp;&nbsp;&nbsp;
date = Date.today<br>&nbsp;&nbsp;&nbsp;
controller.should_render :partial => ''calendar'', :locals
=> {:start_date => date, :event_calendar_data =>
@mock_event_calendar_data}<br>&nbsp;&nbsp;&nbsp; get
''ajax_calendar'', :date =>
Date.today.strftime("%B-%d-%Y")<br>&nbsp;
end<br><br>here''s another expectation I don''t know
how to
translate:<br>controller.should_render({:controller=>:content_item,
:layout=>"frame",
:action=>:upload_image})<br><br>Does anybody have any ideas about
how to get these things working in the new RSpec?<br><br>Thanks for
your help,<br>-Jake Scruggs<br></font>

On 6/19/07, Jake Scruggs <JScruggs at thoughtworks.com>
wrote:
> I''m working on a large Rails site and we want to move from RSpec
0.8.2 to
> the latest and greatest.  So we ran the translator and yet we''re
having a
> lot of trouble translating should_render.
>
> I found this on the web:
>
> We will NOT be supporting the following in the new syntax:
>   controller.should_render
>   controller.should_redirect_to
>
> You will be able to use instead:
>   response.should render_template
>   response.should render_text
>   response.should redirect_to
>
> But the problem I have is that render_template doesn''t have the
> functionality that we used in lots of our should_render expectations.  A
lot
> of our should renders specify an action and and a controller, so now the
> change over is slow (we have to figure out which file is being rendered
> instead), but the big problem is that when testing actions that render a
> partial (mostly for ajax calls) we need to test the locals that get passed
> into the template.
>
> here''s a typical spec:
>   specify "the :start_date should equal the date passed in" do
>     @mock_event_calendar_data = mock(''Mock
event_calendar_data'')
>
>
EventCalendarData.should_receive(:new).and_return(@mock_event_calendar_data)
>     date = Date.today
>     controller.should_render :partial => ''calendar'',
:locals => {:start_date
> => date, :event_calendar_data => @mock_event_calendar_data}
>     get ''ajax_calendar'', :date =>
Date.today.strftime("%B-%d-%Y")
>   end
first, move the should_render to AFTER the get call.

On 6/19/07, Jake Scruggs <JScruggs at thoughtworks.com>
wrote:
> I''m working on a large Rails site and we want to move from RSpec
0.8.2 to
> the latest and greatest.  So we ran the translator and yet we''re
having a
> lot of trouble translating should_render.
>
> I found this on the web:
>
> We will NOT be supporting the following in the new syntax:
>   controller.should_render
>   controller.should_redirect_to
>
> You will be able to use instead:
>   response.should render_template
>   response.should render_text
>   response.should redirect_to
>
> But the problem I have is that render_template doesn''t have the
> functionality that we used in lots of our should_render expectations.  A
lot
> of our should renders specify an action and and a controller, so now the
> change over is slow (we have to figure out which file is being rendered
> instead), but the big problem is that when testing actions that render a
> partial (mostly for ajax calls) we need to test the locals that get passed
> into the template.
>
> here''s a typical spec:
>   specify "the :start_date should equal the date passed in" do
>     @mock_event_calendar_data = mock(''Mock
event_calendar_data'')
>
>
EventCalendarData.should_receive(:new).and_return(@mock_event_calendar_data)
>     date = Date.today
>     controller.should_render :partial => ''calendar'',
:locals => {:start_date
> => date, :event_calendar_data => @mock_event_calendar_data}
>     get ''ajax_calendar'', :date =>
Date.today.strftime("%B-%d-%Y")
>   end
>
> here''s another expectation I don''t know how to translate:
> controller.should_render({:controller=>:content_item,
:layout=>"frame",
> :action=>:upload_image})
>
> Does anybody have any ideas about how to get these things working in the
new
> RSpec?
Sorry for not responding sooner. This was functionality we yanked when
we went from should_render to should render_template. To keep the
matchers simple, I''d suggest we add another matcher named
render_action that looked at the hash, or render_with_options. WDYT?

<div><br></div><font
color="#990099">-----rspec-users-bounces@rubyforge.org wrote:
-----<br><br></font>>To:&nbsp;rspec-users&nbsp;<rspec-users@rubyforge.org><br>>From:&nbsp;"David&nbsp;Chelimsky"&nbsp;<dchelimsky@gmail.com><br>>Sent&nbsp;by:&nbsp;rspec-users-bounces@rubyforge.org<br>>Date:&nbsp;06/22/2007&nbsp;09:54AM<br>>Subject:
Re: [rspec-users] Problems translating should_render
from<br>>0.8.2&nbsp;to&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp&nbsp1.0.5<br>><br>>On&nbsp;6/19/07,&nbsp;Jake&nbsp;Scruggs&nbsp;<JScruggs@thoughtworks.com>&nbsp;wrote:<br>>>
I''m working on a large Rails site and we want to move from
RSpec<br>>0.8.2&nbsp;to<br>>> the latest and greatest.
&nbsp;So we ran the translator and yet
we''re<br>>having&nbsp;a<br>>>&nbsp;lot&nbsp;of&nbsp;trouble&nbsp;translating&nbsp;should_render.<br>>><br>>>&nbsp;I&nbsp;found&nbsp;this&nbsp;on&nbsp;the&nbsp;web:<br>>><br>>>&nbsp;We&nbsp;will&nbsp;NOT&nbsp;be&nbsp;supporting&nbsp;the&nbsp;following&nbsp;in&nbsp;the&nbsp;new&nbsp;syntax:<br>>>&nbsp;&nbsp;&nbsp;controller.should_render<br>>>&nbsp;&nbsp;&nbsp;controller.should_redirect_to<br>>><br>>>&nbsp;You&nbsp;will&nbsp;be&nbsp;able&nbsp;to&nbsp;use&nbsp;instead:<br>>>&nbsp;&nbsp;&nbsp;response.should&nbsp;render_template<br>>>&nbsp;&nbsp;&nbsp;response.should&nbsp;render_text<br>>>&nbsp;&nbsp;&nbsp;response.should&nbsp;redirect_to<br>>><br>>>&nbsp;But&nbsp;the&nbsp;problem&nbsp;I&nbsp;have&nbsp;is&nbsp;that&nbsp;render_template&nbsp;doesn''t&nbsp;have&nbsp;the<br>>>
functionality that we used in lots of our
should_render<br>>expectations.&nbsp;&nbsp;A&nbsp;lot<br>>>
of our should renders specify an action and and a controller,
so<br>>now&nbsp;the<br>>> change over is slow (we have
to figure out which file is being<br>>rendered<br>>>
instead), but the big problem is that when testing actions
that<br>>render&nbsp;a<br>>> partial (mostly for ajax
calls) we need to test the locals that
get<br>>passed<br>>>&nbsp;into&nbsp;the&nbsp;template.<br>>><br>>>&nbsp;here''s&nbsp;a&nbsp;typical&nbsp;spec:<br>>>&nbsp;&nbsp;&nbsp;specify&nbsp;"the&nbsp;:start_date&nbsp;should&nbsp;equal&nbsp;the&nbsp;date&nbsp;passed&nbsp;in"&nbsp;do<br>>>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;@mock_event_calendar_data&nbsp;=&nbsp;mock(''Mock&nbsp;event_calendar_data'')<br>>><br>>><br>>EventCalendarData.should_receive(:new).and_return(@mock_event_calenda<br>>r_data)<br>>>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;date&nbsp;=&nbsp;Date.today<br>>>
&nbsp; &nbsp; controller.should_render :partial =>
''calendar'', :locals
=><br>>{:start_date<br>>>&nbsp;=>&nbsp;date,&nbsp;:event_calendar_data&nbsp;=>&nbsp;@mock_event_calendar_data}<br>>>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;get&nbsp;''ajax_calendar'',&nbsp;:date&nbsp;=>&nbsp;Date.today.strftime("%B-%d-%Y")<br>>>&nbsp;&nbsp;&nbsp;end<br>>><br>>>&nbsp;here''s&nbsp;another&nbsp;expectation&nbsp;I&nbsp;don''t&nbsp;know&nbsp;how&nbsp;to&nbsp;translate:<br>>>
controller.should_render({:controller=>:content_item,<br>>:layout=>"frame",<br>>>&nbsp;:action=>:upload_image})<br>>><br>>>
Does anybody have any ideas about how to get these things
working<br>>in&nbsp;the&nbsp;new<br>>>&nbsp;RSpec?<br>><br>>Sorry
for not responding sooner. This was functionality we
yanked<br>>when<br>>we&nbsp;went&nbsp;from&nbsp;should_render&nbsp;to&nbsp;should&nbsp;render_template.&nbsp;To&nbsp;keep&nbsp;the<br>>matchers&nbsp;simple,&nbsp;I''d&nbsp;suggest&nbsp;we&nbsp;add&nbsp;another&nbsp;matcher&nbsp;named<br>>render_action&nbsp;that&nbsp;looked&nbsp;at&nbsp;the&nbsp;hash,&nbsp;or&nbsp;render_with_options.&nbsp;WDYT?<br><br>That
would be cool, because right now we have a lot of tests/specs/examples that do
things just like the examples I gave and the time involved in converting all
these of them means that we probably won''t leave RSpec 0.82&nbsp;
anytime soon (if at all).&nbsp; If there was a render_action, then the
conversion would be more of a simple mapping and might only take a day -- and
I''m pretty sure I could&nbsp; convince the business to  give up a
day.<br><br>maybe we could pair on it?,<br>-Jake
Scruggs<br>

On 6/26/07, Jake Scruggs <JScruggs at thoughtworks.com>
wrote:
>
> -----rspec-users-bounces at rubyforge.org wrote: -----
>
> >To: rspec-users <rspec-users at rubyforge.org>
> >From: "David Chelimsky" <dchelimsky at gmail.com>
> >Sent by: rspec-users-bounces at rubyforge.org
> >Date: 06/22/2007 09:54AM
> >Subject: Re: [rspec-users] Problems translating should_render from
> >0.8.2 to 1.0.5
>
> >
> >On 6/19/07, Jake Scruggs <JScruggs at thoughtworks.com> wrote:
> >> I''m working on a large Rails site and we want to move
from RSpec
> >0.8.2 to
> >> the latest and greatest.  So we ran the translator and yet
we''re
> >having a
> >> lot of trouble translating should_render.
> >>
> >> I found this on the web:
> >>
> >> We will NOT be supporting the following in the
> new syntax:
> >>   controller.should_render
> >>   controller.should_redirect_to
> >>
> >> You will be able to use instead:
> >>   response.should render_template
> >>   response.should render_text
> >>   response.should redirect_to
> >>
> >> But the problem I have is that render_template
> doesn''t have the
> >> functionality that we used in lots of our should_render
> >expectations.  A lot
> >> of our should renders specify an action and and a controller, so
> >now the
> >> change over is slow (we have to figure out which file is being
> >rendered
> >> instead), but the big problem is that when testing actions that
> >render a
> >> partial (mostly for ajax calls) we need to test the locals that
get
> >passed
> >> into the template.
> >>
> >> here''s a typical spec:
> >>   specify "the :start_date should equal the date
> passed in" do
> >>     @mock_event_calendar_data = mock(''Mock
> event_calendar_data'')
> >>
> >>
> >EventCalendarData.should_receive(:new).and_return(@mock_event_calenda
> >r_data)
> >>     date = Date.today
> >>     controller.should_render :partial =>
''calendar'', :locals =>
> >{:start_date
> >> => date, :event_calendar_data =>
> @mock_event_calendar_data}
> >>     get ''ajax_calendar'', :date =>
> Date.today.strftime("%B-%d-%Y")
> >>   end
> >>
> >> here''s another expectation I don''t know how to
> translate:
> >> controller.should_render({:controller=>:content_item,
> >:layout=>"frame",
> >> :action=>:upload_image})
> >>
> >> Does anybody have any ideas about how to get these things working
> >in the new
> >> RSpec?
> >
> >Sorry for not responding sooner. This was functionality we yanked
> >when
> >we went from should_render to should render_template.
> To keep the
> >matchers simple, I''d suggest we add another matcher named
> >render_action that looked at the hash, or
> render_with_options. WDYT?
>
> That would be cool, because right now we have a lot of tests/specs/examples
> that do things just like the examples I gave and the time involved in
> converting all these of them means that we probably won''t leave
RSpec 0.82
> anytime soon (if at all).  If there was a render_action, then the
conversion
> would be more of a simple mapping and might only take a day -- and
I''m
> pretty sure I could  convince the business to give up a day.
>
> maybe we could pair on it?,
That''d be great!
> -Jake Scruggs
>
> _______________________________________________
> rspec-users mailing list
> rspec-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-users
>

On 6/26/07, David Chelimsky <dchelimsky at gmail.com>
wrote:
> On 6/26/07, Jake Scruggs <JScruggs at thoughtworks.com> wrote:
> >
> > -----rspec-users-bounces at rubyforge.org wrote: -----
> >
> > >To: rspec-users <rspec-users at rubyforge.org>
> > >From: "David Chelimsky" <dchelimsky at gmail.com>
> > >Sent by: rspec-users-bounces at rubyforge.org
> > >Date: 06/22/2007 09:54AM
> > >Subject: Re: [rspec-users] Problems translating should_render from
> > >0.8.2 to 1.0.5
> >
> > >
> > >On 6/19/07, Jake Scruggs <JScruggs at thoughtworks.com>
wrote:
> > >> I''m working on a large Rails site and we want to
move from RSpec
> > >0.8.2 to
> > >> the latest and greatest.  So we ran the translator and yet
we''re
> > >having a
> > >> lot of trouble translating should_render.
> > >>
> > >> I found this on the web:
> > >>
> > >> We will NOT be supporting the following in the
> > new syntax:
> > >>   controller.should_render
> > >>   controller.should_redirect_to
> > >>
> > >> You will be able to use instead:
> > >>   response.should render_template
> > >>   response.should render_text
> > >>   response.should redirect_to
> > >>
> > >> But the problem I have is that render_template
> > doesn''t have the
> > >> functionality that we used in lots of our should_render
> > >expectations.  A lot
> > >> of our should renders specify an action and and a controller,
so
> > >now the
> > >> change over is slow (we have to figure out which file is
being
> > >rendered
> > >> instead), but the big problem is that when testing actions
that
> > >render a
> > >> partial (mostly for ajax calls) we need to test the locals
that get
> > >passed
> > >> into the template.
> > >>
> > >> here''s a typical spec:
> > >>   specify "the :start_date should equal the date
> > passed in" do
> > >>     @mock_event_calendar_data = mock(''Mock
> > event_calendar_data'')
> > >>
> > >>
> >
>EventCalendarData.should_receive(:new).and_return(@mock_event_calenda
> > >r_data)
> > >>     date = Date.today
> > >>     controller.should_render :partial =>
''calendar'', :locals =>
> > >{:start_date
> > >> => date, :event_calendar_data =>
> > @mock_event_calendar_data}
> > >>     get ''ajax_calendar'', :date =>
> > Date.today.strftime("%B-%d-%Y")
> > >>   end
> > >>
> > >> here''s another expectation I don''t know how
to
> > translate:
> > >> controller.should_render({:controller=>:content_item,
> > >:layout=>"frame",
> > >> :action=>:upload_image})
> > >>
> > >> Does anybody have any ideas about how to get these things
working
> > >in the new
> > >> RSpec?
> > >
> > >Sorry for not responding sooner. This was functionality we yanked
> > >when
> > >we went from should_render to should render_template.
> > To keep the
> > >matchers simple, I''d suggest we add another matcher named
> > >render_action that looked at the hash, or
> > render_with_options. WDYT?
> >
> > That would be cool, because right now we have a lot of
tests/specs/examples
> > that do things just like the examples I gave and the time involved in
> > converting all these of them means that we probably won''t
leave RSpec 0.82
> > anytime soon (if at all).  If there was a render_action, then the
conversion
> > would be more of a simple mapping and might only take a day -- and
I''m
> > pretty sure I could  convince the business to give up a day.
> >
> > maybe we could pair on it?,
>
> That''d be great!
So Jake came by last night and we paired on this and got it solved.
You can read about the solution here:

http://blog.davidchelimsky.net/articles/2007/06/28/template-expects_render

Cheers,
David
>
> > -Jake Scruggs
> >
> > _______________________________________________
> > rspec-users mailing list
> > rspec-users at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/rspec-users
> >
>