Jason Garber
2009-May-07 12:03 UTC
Patches for matching opening and closing inline modifiers...
Thanks, Tyson. I''m finishing off a big Radiant extension and then I''ll get back to tending to RedCloth and apply your patches. Thanks so much! Sent from my iPod On May 6, 2009, at 10:52 AM, Tyson Whitehead <twhitehead at gmail.com> wrote:> I put together some patches to fix issues with pairing up opening > and closing > inline modifiers. The new behaviour requires the closing modifier > to be > followed by white space (optionally separated by punctuation). This > fixes > things like bug #110. That is, now > > RedCloth.new("**_snake_case_**").to_html > => "<p><b><em>snake_case</em></b></p>" > > where the middle _ would have matched the leading _ before. > > I attached them and sent of an email to the list earlier, but it > wound up in > the holding tanking due to it size, so I added them to bug #110 > instead. > > 0001-Added-an-end-marker-for-the-A-block-instead-of-assum.patch > 0002-Added-an-end-marker-for-the-B-block-instead-of-assum.patch > 0003-Use-new-end-markers-to-scan-past-ends-to-properly-de.patch > > Running against the test suite will show that 13 failures. Two of > these are > items the previous version did wrong (i.e., now **** -> <strong>**</ > strong> > and the __ in Amanita__s is not paired with the opening one). The > remainder > are due to it now consistently removing one level of space around - > and --. > > This later action is an outcome of the rewrite of the - and -- > handlers. > While the old could be obtained with a bit more work, I''m not sure > this is > actually desirable. The new behaviour is consistent between en and > em dashes, > it is closer to what textile.com gives, it is what my editor claims is > correct, and makes it possible to not get en dash space (e.g., 1993 > - 94). > > Cheers! -Tyson > _______________________________________________ > Redcloth-upwards mailing list > Redcloth-upwards at rubyforge.org > http://rubyforge.org/mailman/listinfo/redcloth-upwards