... this.blocks = box.getElementsByClassName("day-choice"); // box is a div element this.blocks.push(box.down(".day-choice-other")); ... It seems that the code after this line breaks. Maybe there is some code behind these prototype functions that is not compatible with javascript 1.8? The code above works fine in firefox 2 and IE 6. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Hi, Firefox 3''s native implementation of getElementsByClassName returns a node collection rather than an array. This is why your code doesn''t work (node collections don''t implement the push method)... and this is also why getElementsByClassName was deprecated in 1.6. Please use Element#select instead, like so: this.blocks = box.select(".day-choice"); // box is a div element this.blocks.push(box.down(".day-choice-other")); Best, Tobie On Jan 28, 11:07 am, naktinis <nakti...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> ... > this.blocks = box.getElementsByClassName("day-choice"); // box is a > div element > this.blocks.push(box.down(".day-choice-other")); > ... > > It seems that the code after this line breaks. > Maybe there is some code behind these prototype functions that is not > compatible with javascript 1.8? > > The code above works fine in firefox 2 and IE 6.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
thanks, that was the solution. Tobie Langel wrote:> Hi, > > Firefox 3''s native implementation of getElementsByClassName returns a > node collection rather than an array. > > This is why your code doesn''t work (node collections don''t implement > the push method)... and this is also why getElementsByClassName was > deprecated in 1.6. > > Please use Element#select instead, like so: > > this.blocks = box.select(".day-choice"); // box is a > div element > this.blocks.push(box.down(".day-choice-other")); > > Best, > > Tobie > > On Jan 28, 11:07�am, naktinis <nakti...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > ... > > this.blocks = box.getElementsByClassName("day-choice"); // box is a > > div element > > this.blocks.push(box.down(".day-choice-other")); > > ... > > > > It seems that the code after this line breaks. > > Maybe there is some code behind these prototype functions that is not > > compatible with javascript 1.8? > > > > The code above works fine in firefox 2 and IE 6.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---