Rails spinoffs - Jan 2008 - prototype.js craches with another script

When i use prototype.js the script under wont work.
Can you tell me why it dosent work?

var temp, temp2, cookieArray, cookieArray2, cookieCount;
function filetree(){
  cookieCount=0;
  if(document.cookie){
    cookieArray=document.cookie.split(";");
    cookieArray2=new Array();
    for(i in cookieArray){
      cookieArray2[cookieArray[i].split("=")[0].replace(/ /
g,"")]=cookieArray[i].split("=")[1].replace(/
/g,"");
    }
  }
  cookieArray=(document.cookie.indexOf("state=")>=0)?
cookieArray2["state"].split(","):new Array();
  temp=document.getElementById("containerul");
  for(var o=0;o<temp.getElementsByTagName("li").length;o++){
    if(temp.getElementsByTagName("li")
[o].getElementsByTagName("ul").length>0){
      temp2 = document.createElement("span");
      temp2.className = "symbols";
      temp2.style.backgroundImage = (cookieArray.length>0)?
((cookieArray[cookieCount]=="true")?"url(images/
minus.gif)":"url(images/plus.gif)"):"url(images/plus.gif)";
      temp2.onclick=function(){
        showhide(this.parentNode);
        writeCookie();
      }
      temp.getElementsByTagName("li")
[o].insertBefore(temp2,temp.getElementsByTagName("li")[o].firstChild)
     
temp.getElementsByTagName("li")[o].getElementsByTagName("ul")
[0].style.display = "none";
      if(cookieArray[cookieCount]=="true"){
        showhide(temp.getElementsByTagName("li")[o]);
      }
      cookieCount++;
    }
    else{
      temp2 = document.createElement("span");
      temp2.className = "symbols";
      temp2.style.backgroundImage = "url(images/page.gif)";
      temp.getElementsByTagName("li")
[o].insertBefore(temp2,temp.getElementsByTagName("li")[o].firstChild);
    }
  }
}

function showhide(el){
  el.getElementsByTagName("ul")
[0].style.display=(el.getElementsByTagName("ul")
[0].style.display=="block")?"none":"block";
  el.getElementsByTagName("span")
[0].style.backgroundImage=(el.getElementsByTagName("ul")
[0].style.display=="block")?"url(images/minus.gif)":"url(images/
plus.gif)";
}

function writeCookie(){ // Runs through the menu and puts the "states"
of each nested list into an array, the array is then joined together
and assigned to a cookie.
  cookieArray=new Array()
  for(var q=0;q<temp.getElementsByTagName("li").length;q++){
    if(temp.getElementsByTagName("li")[q].childNodes.length>0){
      if(temp.getElementsByTagName("li")
[q].childNodes[0].nodeName=="SPAN" &&
temp.getElementsByTagName("li")
[q].getElementsByTagName("ul").length>0){
 
cookieArray[cookieArray.length]=(temp.getElementsByTagName("li")
[q].getElementsByTagName("ul")[0].style.display=="block");
      }
    }
  }
 
document.cookie="state="+cookieArray.join(",")+";expires="+new
Date(new Date().getTime() + 365*24*60*60*1000).toGMTString();
}
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

mychos wrote:
> ...
>     for(i in cookieArray){
>       cookieArray2[cookieArray[i].split("=")[0].replace(/ /
> g,"")]=cookieArray[i].split("=")[1].replace(/
/g,"");
>     }
>   }....
This part is an incorrect use of an Array as an object.  Iterating 
through an Array with the for...in construct might as well be iterating 
through a Boolean with for...in.  Prototype adds properties to arrays 
such as each() and include() methods.

The for...in line can be easily changed to:

for (var i = 0, length = cookieArray.length; i < length; i++) {


- Ken Snyder

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

Thank you! It work like a charm :)
I never thought i would get it to work.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---