Hi.
With regard to changeset 8149
(http://dev.rubyonrails.org/changeset/8149), there are 2 more
undefined comparisons which could/should use Object.isUndefined. Both
are negative tests, so that may be why...
toQueryParams: function(separator) {
...
if (value != undefined) value = decodeURIComponent(value);
...
},
if (value != undefined) value = decodeURIComponent(value);
could be
if (!Object.isUndefined(value)) value = decodeURIComponent(value);
Also, Form.Element.Methods.serialize has ...
Form.Element.Methods = {
serialize: function(element) {
...
if (value != undefined) {
...
could be
if (!Object.isUndefined(value)) {
--
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---
Hi, There''s a pretty big difference between != undefined and !=undefined: null != undefined // -> false null !== undefined // -> true That''s why these were "missed-out". Best, Tobie --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Richard Quadling
2007-Nov-26 15:20 UTC
Re: Possibly missed an undefineds for changeset 8149.
Ah. Yes. OK. I see. Thank you. On 26/11/2007, Tobie Langel <tobie.langel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> > Hi, > > There''s a pretty big difference between != undefined and !=> undefined: > > null != undefined > // -> false > > null !== undefined > // -> true > > That''s why these were "missed-out". > > Best, > > Tobie > > > >-- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!" --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
To avoid confusion, I could have changed them to != null. That would have been better. Will do so asap. So thanks for the heads up! Best, Tobie On Nov 26, 4:20 pm, "Richard Quadling" <rquadl...-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:> Ah. Yes. OK. I see. Thank you. > > On 26/11/2007, Tobie Langel <tobie.lan...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > > > > > Hi, > > > There''s a pretty big difference between != undefined and !=> > undefined: > > > null != undefined > > // -> false > > > null !== undefined > > // -> true > > > That''s why these were "missed-out". > > > Best, > > > Tobie > > -- > ----- > Richard Quadling > Zend Certified Engineer :http://zend.com/zce.php?c=ZEND002498&r=213474731 > "Standing on the shoulders of some very clever giants!"--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Richard Quadling
2007-Nov-27 08:35 UTC
Re: Possibly missed an undefineds for changeset 8149.
On 26/11/2007, Tobie Langel <tobie.langel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> > To avoid confusion, I could have changed them to != null. > > That would have been better. > > Will do so asap. > > So thanks for the heads up! > > Best, > > TobieGlad to have helped ... I think ... you never know sometimes! And thank you to you all for your work. I get paid because of you! And no, you can''t have any of my money!> > On Nov 26, 4:20 pm, "Richard Quadling" <rquadl...-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> > wrote: > > Ah. Yes. OK. I see. Thank you. > > > > On 26/11/2007, Tobie Langel <tobie.lan...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > > > > > > > > > > > Hi, > > > > > There''s a pretty big difference between != undefined and !=> > > undefined: > > > > > null != undefined > > > // -> false > > > > > null !== undefined > > > // -> true > > > > > That''s why these were "missed-out". > > > > > Best, > > > > > Tobie > > > > -- > > ----- > > Richard Quadling > > Zend Certified Engineer :http://zend.com/zce.php?c=ZEND002498&r=213474731 > > "Standing on the shoulders of some very clever giants!" > > >-- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!" --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Half''s fine ;) On Nov 27, 9:35 am, "Richard Quadling" <rquadl...-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:> And thank you to you all for your work. I get paid because of you! And > no, you can''t have any of my money!--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---