Rails spinoffs - Oct 2007 - Pedantic observation regarding prototype.js Ajax.Request 'postBody' - minor bug?

I was just modifying some of the Request code to run in a Firefox
plugin environment when I noticed that AjaxRequest would fail (I''m
pretty sure) to send a body with the sole content being the number 0
or the value false:

the line in question is:
this.body = this.method == ''post'' ? (this.options.postBody ||
params) : null;

in the function:
Ajax.Request.prototype.request


prototype.js version 1.5.1.1


Cheers,


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

Geoff,

Thanks for the heads up.  Although this hits on what''s pretty much an 
edge case, I encourage you to look up our patch submission guidelines 
and perhaps dedicate a moment to whipping up a tested patch for this? 
That would be lovely.

Cheers,

-- 
Christophe Porteneuve aka TDD
tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---