Rails spinoffs - Aug 2007 - Var declaration problem with 1.6.0 pre1

Hi all,

I believe I found a problem with the 1.6.0_pre1 version, see the code
below:

The variable ''event'' should be declared above the if-then-else
statement.  The existing code will not work correctly if compressed
using the Dojo compressor.

1.6.0 looks great, but please fix this issue :)

    fire: function(element, eventName, memo) {
      element = $(element);
      if (element == document && document.createEvent && !
element.dispatchEvent)
        element = document.documentElement;

      if (document.createEvent) {
        var event = document.createEvent("HTMLEvents");
        event.initEvent("dataavailable", true, true);
      } else {
        var event = document.createEventObject();
        event.eventType = "ondataavailable";
      }

      event.eventName = eventName;
      event.memo = memo || { };

      if (document.createEvent) {
        element.dispatchEvent(event);
      } else {
        element.fireEvent(event.eventType, event);
      }

      return element;
    }

Thx,
Les


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

Les wrote:
> The existing code will not work correctly if compressed
> using the Dojo compressor.
Sounds like a problem with the Dojo compressor. This is perfectly valid. In
Javascript variables are function scoped, not lexically scoped. So you can
declare a variable at the end of a function and use it at the beginning if you
want, although that''s a really silly thing to do.

Having said that... It does hurt my eyes to see the same variable declared twice
in the same function :)

-- 
Michael Peters
Developer
Plus Three, LP


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---