Christophe Porteneuve
2007-Jul-19 07:26 UTC
InPlace[Collection]Editor rewrite: it''s in trunk!
Hi all, For those of you who don''t follow Thomas Fuch''s blog, know that a complete rewrite of InPlaceEditor / InPlaceCollectionEditor just made it into the trunk. You''ll find all the juicy details on Thomas'' post: http://mir.aculo.us/2007/7/17/in-place-editing-the-summer-2007-rewrite Do note that this is my rewrite, so if you find bugs etc., don''t go yelling at Thomas: I''m the one to blame! We''ve seen a striking increase of posts here about IPE, and I can only hope you''ll find the new version great. A lot of you monkeypatched your IPE to fit your needs, and this monkeypatching may very well need to be ported over to the new release before you can use it confidently. As always: test like crazy! Cheers, -- Christophe Porteneuve a.k.a. TDD "[They] did not know it was impossible, so they did it." --Mark Twain Email: tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Andrew Kaspick
2007-Jul-23 05:50 UTC
Re: InPlace[Collection]Editor rewrite: it''s in trunk!
Glad to finally see the rewrite... good work. Looking at the code, I see no way to customize the created input control. For example, I''d like to be able to set the maxlength attribute on the input control. Could a callback be added so that once the control is created, other attributes, or performing further customization could be done? Something like this... if (this.options.submitOnBlur) fld.onblur = this._boundSubmitHandler; +if (this.options.customizeEditField) + this.options.customizeEditField(fld); this._controls.editor = fld; Thanks, Andrew On 7/19/07, Christophe Porteneuve <tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org> wrote:> > Hi all, > > For those of you who don''t follow Thomas Fuch''s blog, know that a > complete rewrite of InPlaceEditor / InPlaceCollectionEditor just made it > into the trunk. > > You''ll find all the juicy details on Thomas'' post: > > http://mir.aculo.us/2007/7/17/in-place-editing-the-summer-2007-rewrite > > Do note that this is my rewrite, so if you find bugs etc., don''t go > yelling at Thomas: I''m the one to blame! > > We''ve seen a striking increase of posts here about IPE, and I can only > hope you''ll find the new version great. A lot of you monkeypatched your > IPE to fit your needs, and this monkeypatching may very well need to be > ported over to the new release before you can use it confidently. As > always: test like crazy! > > Cheers, > > -- > Christophe Porteneuve a.k.a. TDD > "[They] did not know it was impossible, so they did it." --Mark Twain > Email: tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Andrew Kaspick
2007-Jul-23 07:20 UTC
Re: InPlace[Collection]Editor rewrite: it''s in trunk!
I was working on this just before you posted your message here. I wrote a plugin for rails to replace the in_place_editor method so that it accept all Ajax.InPlaceEditor options, so it will work with this new rewrite. It can be found here... http://agilewebdevelopment.com/plugins/improved_in_place_editor I just posted it, so feedback is welcome. Andrew On 7/23/07, Andrew Kaspick <akaspick-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Glad to finally see the rewrite... good work. > > Looking at the code, I see no way to customize the created input control. > > For example, I''d like to be able to set the maxlength attribute on the > input control. Could a callback be added so that once the control is > created, other attributes, or performing further customization could > be done? > > Something like this... > > if (this.options.submitOnBlur) > fld.onblur = this._boundSubmitHandler; > > +if (this.options.customizeEditField) > + this.options.customizeEditField(fld); > > this._controls.editor = fld; > > Thanks, > Andrew > > On 7/19/07, Christophe Porteneuve <tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org> wrote: > > > > Hi all, > > > > For those of you who don''t follow Thomas Fuch''s blog, know that a > > complete rewrite of InPlaceEditor / InPlaceCollectionEditor just made it > > into the trunk. > > > > You''ll find all the juicy details on Thomas'' post: > > > > http://mir.aculo.us/2007/7/17/in-place-editing-the-summer-2007-rewrite > > > > Do note that this is my rewrite, so if you find bugs etc., don''t go > > yelling at Thomas: I''m the one to blame! > > > > We''ve seen a striking increase of posts here about IPE, and I can only > > hope you''ll find the new version great. A lot of you monkeypatched your > > IPE to fit your needs, and this monkeypatching may very well need to be > > ported over to the new release before you can use it confidently. As > > always: test like crazy! > > > > Cheers, > > > > -- > > Christophe Porteneuve a.k.a. TDD > > "[They] did not know it was impossible, so they did it." --Mark Twain > > Email: tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org > > > > > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Andrew Kaspick
2007-Jul-25 19:12 UTC
Re: InPlace[Collection]Editor rewrite: it''s in trunk!
Hey Christophe, I submitted a patch for this at http://dev.rubyonrails.org/ticket/9103 Thanks, Andrew On 7/23/07, Andrew Kaspick <akaspick-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Glad to finally see the rewrite... good work. > > Looking at the code, I see no way to customize the created input control. > > For example, I''d like to be able to set the maxlength attribute on the > input control. Could a callback be added so that once the control is > created, other attributes, or performing further customization could > be done? > > Something like this... > > if (this.options.submitOnBlur) > fld.onblur = this._boundSubmitHandler; > > +if (this.options.customizeEditField) > + this.options.customizeEditField(fld); > > this._controls.editor = fld; > > Thanks, > Andrew > > On 7/19/07, Christophe Porteneuve <tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org> wrote: > > > > Hi all, > > > > For those of you who don''t follow Thomas Fuch''s blog, know that a > > complete rewrite of InPlaceEditor / InPlaceCollectionEditor just made it > > into the trunk. > > > > You''ll find all the juicy details on Thomas'' post: > > > > http://mir.aculo.us/2007/7/17/in-place-editing-the-summer-2007-rewrite > > > > Do note that this is my rewrite, so if you find bugs etc., don''t go > > yelling at Thomas: I''m the one to blame! > > > > We''ve seen a striking increase of posts here about IPE, and I can only > > hope you''ll find the new version great. A lot of you monkeypatched your > > IPE to fit your needs, and this monkeypatching may very well need to be > > ported over to the new release before you can use it confidently. As > > always: test like crazy! > > > > Cheers, > > > > -- > > Christophe Porteneuve a.k.a. TDD > > "[They] did not know it was impossible, so they did it." --Mark Twain > > Email: tdd-x+CfDp/qHev2eFz/2MeuCQ@public.gmane.org > > > > > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---