Hi all,
currently Element.setStyle() converts the ''float'' css property
to
''cssFloat'' or ''styleFloat'' to account for
the different browser
implementations.
As ''float'' is a reserved keyword, an error will be thrown on
$(element).setStyle({float: ''none''}) for example.
However, this will work: $(element).setStyle({''float'':
''none''})
(notice the apostrophes around float).
My question is: should this be kept that way, or should we force the
use of ''cssFloat'' ?
Note: ''cssFloat'' is the standard way to access the CSS float
property
via DOM scripting (see
http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties-cssFloat)
Regards,
Tobie
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---
Note that I''ve only noticed this being an issue in Safari (haven''t tested in IE6 or 7) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
I guess the best thing would be to have support for
{cssFloat:''blah''} and
{''float'':''blah''}
with auto-workarounds for the browser quirks.
Best,
Thomas
Am 20.12.2006 um 22:07 schrieb tobie:
>
> Hi all,
>
> currently Element.setStyle() converts the ''float'' css
property to
> ''cssFloat'' or ''styleFloat'' to account
for the different browser
> implementations.
>
> As ''float'' is a reserved keyword, an error will be thrown
on
> $(element).setStyle({float: ''none''}) for example.
>
> However, this will work: $(element).setStyle({''float'':
''none''})
> (notice the apostrophes around float).
>
> My question is: should this be kept that way, or should we force the
> use of ''cssFloat'' ?
>
> Note: ''cssFloat'' is the standard way to access the CSS
float property
> via DOM scripting (see
> http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties-
> cssFloat)
>
> Regards,
>
> Tobie
>
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---
Thanks Thomas, That''s also the conclusion I had arrived too after posting this. I''ll post a patch later today. Cheers, Tobie --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
Heya, No sweat, I''m probably offline (or mostly offline) for a few days because of xmas celebrations. Wish you (all) happy holidays and a great new year! :) Best, Thomas Am 21.12.2006 um 19:08 schrieb tobie:> > Thanks Thomas, > > That''s also the conclusion I had arrived too after posting this. > > I''ll post a patch later today. > > Cheers, > > Tobie > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---