Doug Barth
2013-Nov-12 12:03 UTC
[#12779] Don''t swallow exceptions in transctional statements
Hi, I have a pull request open for changing the MySQL adapters that I''d love to get reviewed. The gist is the current adapter code swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. During the process of moving over to a multi-master Galera cluster, we found that this behavior was causing our application to returns a successful response even though the database transaction failed to apply. Galera''s replication system is expected to return an error on COMMIT if the transaction failed the certification process. Similarly, it''s possible to have BEGIN fail if you have causal reads enabled and the database times out waiting for queue writesets to be applied. https://github.com/rails/rails/pull/12779 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.