Prem Sichanugrist
2013-Oct-26 08:14 UTC
`sprockets-rails ~> 2.0.0` as `rails`''s dependency?
I just noticed that `rails` gem actually requires `sprocket-rails` as a runtime dependency. (According to https://rubygems.org/gems/rails) I would think that you only need s-r gem only if you enable asset pipeline. Should that dependency be moved to AP, Railtie, or removed? Thanks, Prem -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
Rafael Mendonça França
2013-Oct-27 01:16 UTC
Re: `sprockets-rails ~> 2.0.0` as `rails`''s dependency?
I don’t think we need to change. This is like we do activerecord gem, even if you disable it the gem will be installed. When you disable the assets pipeline we just don’t load the sprockets-rails railtie. If people don’t want to install tem gems they should pick the wanted gems in the gemfile removing the rails gem. Some time ago I opened a PR to change the way these options works<https://github.com/rails/rails/pull/5703>but we conclude that it is not worth and would make harder to people add back the components. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Sat, Oct 26, 2013 at 6:14 AM, Prem Sichanugrist <sikandsak@gmail.com>wrote:> I just noticed that `rails` gem actually requires `sprocket-rails` as a > runtime dependency. (According to https://rubygems.org/gems/rails) I > would think that you only need s-r gem only if you enable asset pipeline. > Should that dependency be moved to AP, Railtie, or removed? > > Thanks, > > Prem > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.