Hi, I''ve got a bugfix PR[1] on master, which I''d really like (if possible) to make it into the final 3.2 bugfix release as a backport. Is it out of order to open a backport PR for something that hasn''t yet been merged into master? I''m conscious of the heavy existing workload on maintainers, and don''t want to add to it unnecessarily - just also aware that there''s a cutoff for 3.2 bugfixes hoving into view... :-) All the best, Simon [1] https://github.com/rails/rails/pull/11636 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
You should mention in the comment there that this effects 3.2, 4.0 and master, and you think this should be backported. After it got merged into master, then usually the core team will ask you to create associated PRs. No need to do it up front. ;) -Prem On Wednesday, August 21, 2013 at 1:03 PM, Simon Coffey wrote:> Hi, > > I''ve got a bugfix PR[1] on master, which I''d really like (if possible) to make it into the final 3.2 bugfix release as a backport. > > Is it out of order to open a backport PR for something that hasn''t yet been merged into master? I''m conscious of the heavy existing workload on maintainers, and don''t want to add to it unnecessarily - just also aware that there''s a cutoff for 3.2 bugfixes hoving into view... :-) > > All the best, > Simon > > [1] https://github.com/rails/rails/pull/11636 > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com (mailto:rubyonrails-core+unsubscribe@googlegroups.com). > To post to this group, send email to rubyonrails-core@googlegroups.com (mailto:rubyonrails-core@googlegroups.com). > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
:+1: for what Prem said. We have to check that the bug fix will not introduce some kind of breaking change in a stable release before backporting. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Wed, Aug 21, 2013 at 2:28 PM, Prem Sichanugrist <sikandsak@gmail.com>wrote:> You should mention in the comment there that this effects 3.2, 4.0 and > master, and you think this should be backported. After it got merged into > master, then usually the core team will ask you to create associated PRs. > No need to do it up front. ;) > > -Prem > > On Wednesday, August 21, 2013 at 1:03 PM, Simon Coffey wrote: > > Hi, > > I''ve got a bugfix PR[1] on master, which I''d really like (if possible) to > make it into the final 3.2 bugfix release as a backport. > > Is it out of order to open a backport PR for something that hasn''t yet > been merged into master? I''m conscious of the heavy existing workload on > maintainers, and don''t want to add to it unnecessarily - just also aware > that there''s a cutoff for 3.2 bugfixes hoving into view... :-) > > All the best, > Simon > > [1] https://github.com/rails/rails/pull/11636 > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
On Wednesday, August 21, 2013 6:30:37 PM UTC+1, Rafael Mendonça França wrote:> > > On Wed, Aug 21, 2013 at 2:28 PM, Prem Sichanugrist <sika...@gmail.com<javascript:> > > wrote: > >> You should mention in the comment there that this effects 3.2, 4.0 and >> master, and you think this should be backported. After it got merged into >> master, then usually the core team will ask you to create associated PRs. >> No need to do it up front. ;) >> >:+1: for what Prem said. We have to check that the bug fix will not> introduce some kind of breaking change in a stable release before > backporting.Great, makes sense - thanks very much! Simon -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
Also, if you open a backport PR immediately, and we decide not to accept the patch, it''s just clutter. Better to get it actually merged first, then backport. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.