Hello. Rails'' generator generator is missing hook for :test_framework and it doesn''t generate some basic dumb test. I can do this and send pull request, I just want to be sure if this is potentially mergable. Anyone can review this idea and give me red/green on this feature? Thanks, Josef -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
If there is functionality with no tests, a test for that functionality would be welcome. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
Info taken from rails g generator --help:
Example:
`rails generate generator Awesome`
creates a standard awesome generator:
lib/generators/awesome/
lib/generators/awesome/awesome_generator.rb
lib/generators/awesome/USAGE
lib/generators/awesome/templates/
I think we should add this file:
test/lib/generators/awesome_generator_test.rb
with some basic template (like
https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_unit/helper/templates/helper_test.rb)
for start or with pending test.
What do you think Steve? Should I start implementing this?
Dne pátek, 12. července 2013 19:13:16 UTC+2 Steve Klabnik
napsal(a):>
> If there is functionality with no tests, a test for that functionality
> would be welcome.
>
--
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to rubyonrails-core+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/groups/opt_out.
I created pull request for this. https://github.com/rails/rails/pull/11419 Dne pátek, 12. července 2013 19:13:16 UTC+2 Steve Klabnik napsal(a):> > If there is functionality with no tests, a test for that functionality > would be welcome. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.