Issue: It breaks compatibility with old good Log4r and default ::Logger. I found that issue today while trying to setup custom logger. The cause is the new ActiveSupport::Logger#silence method, which is called by ActiveRecord pending migration checker. Another issue is that the Kernel has its own #silence method which is called instead of ActiveSupport::Logger#silence (when ::Logger used). Seem like names conflict. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
#squelch ??? On Mon, May 6, 2013 at 10:55 PM, laise <a.y.chernenkov@gmail.com> wrote:> Issue: > > It breaks compatibility with old good Log4r and default ::Logger. I found > that issue today while trying to setup custom logger. The cause is the new > ActiveSupport::Logger#silence method, which is called by ActiveRecord > pending migration checker. > > Another issue is that the Kernel has its own #silence method which is > called instead of ActiveSupport::Logger#silence (when ::Logger used). Seem > like names conflict. > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Discussion here: https://github.com/rails/rails/issues/10789 On Tuesday, May 7, 2013 10:41:13 PM UTC+6, Chad Woolley wrote:> > #squelch ??? > > > On Mon, May 6, 2013 at 10:55 PM, laise <a.y.che...@gmail.com <javascript:> > > wrote: > >> Issue: >> >> It breaks compatibility with old good Log4r and default ::Logger. I found >> that issue today while trying to setup custom logger. The cause is the new >> ActiveSupport::Logger#silence method, which is called by ActiveRecord >> pending migration checker. >> >> Another issue is that the Kernel has its own #silence method which is >> called instead of ActiveSupport::Logger#silence (when ::Logger used). Seem >> like names conflict. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-co...@googlegroups.com <javascript:>. >> To post to this group, send email to rubyonra...@googlegroups.com<javascript:> >> . >> Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en >> . >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.