kenips
2013-Jan-31 22:11 UTC
ActiveRecord - Should hstore extension be created automatically?
Hi all, Just wondering if you guys think hstore extension should be created automatically by rails? I see that in ActiveRecord''s Rakefile it''s been updated for testing ( https://github.com/rails/rails/blob/master/activerecord/Rakefile#L124-131), but this doesn''t seem to be right for every rails app to do so. Should this be something handled byActiveRecord::Tasks::PostgreSQLDatabaseTasks? Alternatively we could promote adding hstore to the psql template db in guides: http://dwradcliffe.com/2013/01/10/install-hstore-to-default-template.html -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Rafael Mendonça França
2013-Jan-31 22:42 UTC
Re: ActiveRecord - Should hstore extension be created automatically?
I don''t think it should be added by default. Not every application will use it. On Jan 31, 2013 8:12 PM, "kenips" <ken.ip@pushpulllabs.com> wrote:> Hi all, > > Just wondering if you guys think hstore extension should be created > automatically by rails? I see that in ActiveRecord''s Rakefile it''s been > updated for testing ( > https://github.com/rails/rails/blob/master/activerecord/Rakefile#L124-131), > but this doesn''t seem to be right for every rails app to do so. Should this > be something handled byActiveRecord::Tasks::PostgreSQLDatabaseTasks? > > Alternatively we could promote adding hstore to the psql template db in > guides: > http://dwradcliffe.com/2013/01/10/install-hstore-to-default-template.html > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Prem Sichanugrist
2013-Jan-31 22:45 UTC
Re: ActiveRecord - Should hstore extension be created automatically?
yeah, -1 by default, but +1 for a patch that would allow me to do it without having to switch to structure.sql :) On Thursday, January 31, 2013 at 5:42 PM, Rafael Mendonça França wrote:> I don''t think it should be added by default. Not every application will use it. > On Jan 31, 2013 8:12 PM, "kenips" <ken.ip@pushpulllabs.com (mailto:ken.ip@pushpulllabs.com)> wrote: > > > > Hi all, > > > > > > Just wondering if you guys think hstore extension should be created automatically by rails? I see that in ActiveRecord''s Rakefile it''s been updated for testing (https://github.com/rails/rails/blob/master/activerecord/Rakefile#L124-131), but this doesn''t seem to be right for every rails app to do so. Should this be something handled byActiveRecord::Tasks::PostgreSQLDatabaseTasks? > > > > > > Alternatively we could promote adding hstore to the psql template db in guides: > > http://dwradcliffe.com/2013/01/10/install-hstore-to-default-template.html > > > > > > -- > > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com (mailto:rubyonrails-core%2Bunsubscribe@googlegroups.com). > > To post to this group, send email to rubyonrails-core@googlegroups.com (mailto:rubyonrails-core@googlegroups.com). > > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com (mailto:rubyonrails-core+unsubscribe@googlegroups.com). > To post to this group, send email to rubyonrails-core@googlegroups.com (mailto:rubyonrails-core@googlegroups.com). > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Rafael Mendonça França
2013-Jan-31 22:46 UTC
Re: ActiveRecord - Should hstore extension be created automatically?
It is already implemented Prem. See the last commits from Aaron. On Jan 31, 2013 8:45 PM, "Prem Sichanugrist" <sikandsak@gmail.com> wrote:> yeah, -1 by default, but +1 for a patch that would allow me to do it > without having to switch to structure.sql :) > > On Thursday, January 31, 2013 at 5:42 PM, Rafael Mendonça França wrote: > > I don''t think it should be added by default. Not every application will > use it. > On Jan 31, 2013 8:12 PM, "kenips" <ken.ip@pushpulllabs.com> wrote: > > Hi all, > > Just wondering if you guys think hstore extension should be created > automatically by rails? I see that in ActiveRecord''s Rakefile it''s been > updated for testing ( > https://github.com/rails/rails/blob/master/activerecord/Rakefile#L124-131), > but this doesn''t seem to be right for every rails app to do so. Should this > be something handled byActiveRecord::Tasks::PostgreSQLDatabaseTasks? > > Alternatively we could promote adding hstore to the psql template db in > guides: > http://dwradcliffe.com/2013/01/10/install-hstore-to-default-template.html > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Prem Sichanugrist
2013-Jan-31 22:55 UTC
Re: ActiveRecord - Should hstore extension be created automatically?
A+ -Prem Sent from my iPhone On Jan 31, 2013, at 5:46 PM, "Rafael Mendonça França" < rafaelmfranca@gmail.com> wrote: It is already implemented Prem. See the last commits from Aaron. On Jan 31, 2013 8:45 PM, "Prem Sichanugrist" <sikandsak@gmail.com> wrote:> yeah, -1 by default, but +1 for a patch that would allow me to do it > without having to switch to structure.sql :) > > On Thursday, January 31, 2013 at 5:42 PM, Rafael Mendonça França wrote: > > I don''t think it should be added by default. Not every application will > use it. > On Jan 31, 2013 8:12 PM, "kenips" <ken.ip@pushpulllabs.com> wrote: > > Hi all, > > Just wondering if you guys think hstore extension should be created > automatically by rails? I see that in ActiveRecord''s Rakefile it''s been > updated for testing ( > https://github.com/rails/rails/blob/master/activerecord/Rakefile#L124-131), > but this doesn''t seem to be right for every rails app to do so. Should this > be something handled byActiveRecord::Tasks::PostgreSQLDatabaseTasks? > > Alternatively we could promote adding hstore to the psql template db in > guides: > http://dwradcliffe.com/2013/01/10/install-hstore-to-default-template.html > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscribe@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscribe@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. For more options, visit https://groups.google.com/groups/opt_out.