Rails core - Oct 2011 - Arel and a SafeBuffer, redux

Back in March, J. Smith wrote:

I''ve written a patch for Arel to provide a feature similar to the
> ActiveSupport::SafeBuffer class that allows for by-passing some of
Arel''s
> quoting mechanisms when using, say, String#sql_safe, similar to #html_safe.
>
At the time, discussion focused on the ability to pass unquoted literals to 
Arel, which you can already do with Arel.sql. But wouldn''t this also
enable
a (IMHO) much-needed feature: the ability to safely interpolate strings?

Right now, we have to use either array-substitution or hash-substitution, 
neither of which is very readable or DRY. I''ve seen many programmers
(even
those who know better) do interpolations anyway, either absent-mindedly out 
of habit, or because some clauses (i.e. joins()) don''t support them.

Wouldn''t a SafeBuffer allow global support for safe interpolations in a
syntax that everyone already knows? And isn''t that a good thing?

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/rubyonrails-core/-/p-fDeXePFcAJ.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.

On Mon, Oct 31, 2011 at 12:08 PM, Jay Levitt <jay+news@jay.fm>
wrote:
> Back in March, J. Smith wrote:
>
> At the time, discussion focused on the ability to pass unquoted literals to
> Arel, which you can already do with Arel.sql. But wouldn''t this
also enable
> a (IMHO) much-needed feature: the ability to safely interpolate strings?
> Right now, we have to use either array-substitution or hash-substitution,
> neither of which is very readable or DRY. I''ve seen many
programmers (even
> those who know better) do interpolations anyway, either absent-mindedly out
> of habit, or because some clauses (i.e. joins()) don''t support
them.
> Wouldn''t a SafeBuffer allow global support for safe interpolations
in a
> syntax that everyone already knows? And isn''t that a good thing?
>
If anyone is still interested, I still have my patch sitting around
and have rebased it against master and it''s still passing the Arel
test suite, so it should still be working okay. I can post the patch
or fork it to github or whatever if anyone wants to run with it.

Cheers.

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.