Using the following snippet of code to get an image with a mouseover image:
<%= image_tag("button_off.png", :mouseover =>
"button_on.png", :alt =>
:button) %>
Generates inline JavaScript to do the image swapping like so:
<img alt="button"
onmouseout="this.src=''/assets/button_off.png''"
onmouseover="this.src=''/assets/button_on.png''"
src="/assets/button_off.png"
/>
It''s possible (and very simple) to do the image swapping in an UJS
manner:
<img alt="button" data-mouseover="/assets/button_on.png"
src="/assets/button_off.png" />
With the supporting jQuery snippet:
$(''img[data-mouseover]'').hover(
function() {
$(this).data(''_mouseover'',
$(this).attr(''src''));
$(this).attr(''src'',
$(this).data(''mouseover''));
},
function() {
$(this).attr(''src'',
$(this).data(''_mouseover''));
}
);
Is there any specific reason I''m not aware of that Rails still uses
inline
JavaScript for this? Would there be any reception if I were to submit a pull
request for this? Never contributed to rails before so I''m not sure.
Thanks!
--
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/rubyonrails-core/-/dCJvxtgOui4J.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
On Oct 14, 2011, at 6:58 PM, Tim Shaffer wrote:> Is there any specific reason I''m not aware of that Rails still uses inline JavaScript for this? Would there be any reception if I were to submit a pull request for this? Never contributed to rails before so I''m not sure. Thanks!I don''t think you should change this. The reason it was done this way is to implement it in the easiest way possible, and that''s just adding two extra attributes and no supporting code. Your way would require removing this behavior from Rails and implementing it in JS. You would have to contribute to both Rails and rails-ujs & prototype-ujs projects, because the latter implement behaviors around data-* attributes. I don''t think it''s too much work, but I think that you shuldn''t try to improve this. Ones who really care about properly doing image swapping will do so manually and handle advanced things like preloading of images. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
I also don''t think there is any point implementing this particular feature "unobtrusively", because in this context, "unobtrusive" has no meaning. If javascript is disabled in the user''s browser, there would be no difference in behavior between the "unobtrusive" and the current implementations. -Steve Schwartz (@jangosteve) On Oct 15, 2011, at 12:40 PM, Mislav Marohnić wrote:> On Oct 14, 2011, at 6:58 PM, Tim Shaffer wrote: > >> Is there any specific reason I''m not aware of that Rails still uses >> inline JavaScript for this? Would there be any reception if I were >> to submit a pull request for this? Never contributed to rails >> before so I''m not sure. Thanks! > > I don''t think you should change this. The reason it was done this > way is to implement it in the easiest way possible, and that''s just > adding two extra attributes and no supporting code. > > Your way would require removing this behavior from Rails and > implementing it in JS. You would have to contribute to both Rails > and rails-ujs & prototype-ujs projects, because the latter implement > behaviors around data-* attributes. I don''t think it''s too much > work, but I think that you shuldn''t try to improve this. Ones who > really care about properly doing image swapping will do so manually > and handle advanced things like preloading of images. > > -- > You received this message because you are subscribed to the Google > Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails- > core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com > . > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en > .-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Thanks for the input. That''s exactly what I needed to know. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/t4LaRYPA-VcJ. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.