Hi, I was wondering, is it preferable to create GitHub pull requests or git patches for proposed code additions and bug fixes to the Rails core? Thanks Pan Thomakos -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Yes it is, the big man himself replies to them as seen here: https://github.com/rails/rails/pull/204 -- Ryan Bigg On Saturday, 12 March 2011 at 12:37 PM, Pan Thomakos wrote:> Hi, > > I was wondering, is it preferable to create GitHub pull requests or git patches for proposed code additions and bug fixes to the Rails core? > > Thanks > Pan Thomakos > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Nice! The github pull requests are lovely :) Should the guide on contributing be changed then? Iain On Mar 12, 2:40 am, Ryan Bigg <radarliste...@gmail.com> wrote:> Yes it is, the big man himself replies to them as seen here:https://github.com/rails/rails/pull/204 > > -- > Ryan Bigg > > > > > > > > On Saturday, 12 March 2011 at 12:37 PM, Pan Thomakos wrote: > > Hi, > > > I was wondering, is it preferable to create GitHub pull requests or git patches for proposed code additions and bug fixes to the Rails core? > > > Thanks > > Pan Thomakos > > > -- > > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > > For more options, visit this group athttp://groups.google.com/group/rubyonrails-core?hl=en.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.