Hi, This is my first attempt at a contribution to the Ruby on Rails core and I was hoping to get some feedback on my patch: https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters I know the contributing guide indicated that I should tag the post with ''patch'', but I was unable to actually tag the post. I''m guessing this has to do with privileges? Thanks! -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Mar 5, 2011, at 2:43 PM, Pan Thomakos wrote:> Hi, > > This is my first attempt at a contribution to the Ruby on Rails core > and I was hoping to get some feedback on my patch: > > https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters > > I know the contributing guide indicated that I should tag the post > with ''patch'', but I was unable to actually tag the post. I''m guessing > this has to do with privileges?There were some problems with the ever-present spammers clearing tags from tickets, so there''s a restriction on newish users changing tags. I''ve tagged the ticket as ''patch''. What version of Rails does the patch apply to? It doesn''t look *particularly* sensitive to version (since it''s only touching two files) but it will help keep track if you specify what version the patch is for. Thanks, --Matt Jones -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
The patch should apply to the most recent version (Rails 3.0.5?) but I don''t think it''s particular to that version. I have verified that the bug exists in 3.0.4 as well. Thanks On Sat, Mar 5, 2011 at 1:16 PM, Matt Jones <al2o3cr@gmail.com> wrote:> > On Mar 5, 2011, at 2:43 PM, Pan Thomakos wrote: > > > Hi, > > > > This is my first attempt at a contribution to the Ruby on Rails core > > and I was hoping to get some feedback on my patch: > > > > > https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters > > > > I know the contributing guide indicated that I should tag the post > > with ''patch'', but I was unable to actually tag the post. I''m guessing > > this has to do with privileges? > > There were some problems with the ever-present spammers clearing tags from > tickets, so there''s a restriction on newish users changing tags. I''ve tagged > the ticket as ''patch''. > > What version of Rails does the patch apply to? It doesn''t look > *particularly* sensitive to version (since it''s only touching two files) but > it will help keep track if you specify what version the patch is for. > > Thanks, > > --Matt Jones > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- Pan Thomakos pan.thomakos@gmail.com 215.266.9022 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
The patch should apply to the most recent version (Rails 3.0.5?) but I don''t think it''s particular to that version. I have verified that the bug exists in 3.0.4 as well. Thanks, Pan Thomakos On Sat, Mar 5, 2011 at 1:16 PM, Matt Jones <al2o3cr@gmail.com> wrote:> > On Mar 5, 2011, at 2:43 PM, Pan Thomakos wrote: > > > Hi, > > > > This is my first attempt at a contribution to the Ruby on Rails core > > and I was hoping to get some feedback on my patch: > > > > > https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters > > > > I know the contributing guide indicated that I should tag the post > > with ''patch'', but I was unable to actually tag the post. I''m guessing > > this has to do with privileges? > > There were some problems with the ever-present spammers clearing tags from > tickets, so there''s a restriction on newish users changing tags. I''ve tagged > the ticket as ''patch''. > > What version of Rails does the patch apply to? It doesn''t look > *particularly* sensitive to version (since it''s only touching two files) but > it will help keep track if you specify what version the patch is for. > > Thanks, > > --Matt Jones > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.