Hi All, I posted a ticket to the lighthouse (link below), but I realized that this might be a better place for discussion of an issue. I work on a large Rails application which, unfortunately, has an extensively used Fixture model. Also unfortunately we just recently started building up our testing suite and as we''ve been trying to test our Fixture model, we''ve been having issues because the Fixture class which is used in ActiveRecord to load yaml/csv fixtures is overwriting the initialize method (perhaps others). From looking into the ActiveRecord source, it seems like it would be much less work to namespace the Fixture class inside a module than rename our model. In addition, other users of Rails would be able to have a "Fixture" model. I''m willing to do the work and to submit a patch, but I wanted some advice first. Should I namespace just the Fixture class, or should I namespace the other classes inside the fixtures.rb file as well? Should I just put them inside of the ActiveRecord module? Thanks, Brian ;p https://rails.lighthouseapp.com/projects/8994/tickets/6098-activerecord-fixture-class#ticket-6098-1 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
I for one would expect all classes/modules in the activerecord Gem to be namespaced under ActiveRecord::* namespace. On 12/9/2010 5:16 PM, Brian Underwood wrote:> Hi All, > > I posted a ticket to the lighthouse (link below), but I realized that > this might be a better place for discussion of an issue. > > I work on a large Rails application which, unfortunately, has an > extensively used Fixture model. Also unfortunately we just recently > started building up our testing suite and as we''ve been trying to test > our Fixture model, we''ve been having issues because the Fixture class > which is used in ActiveRecord to load yaml/csv fixtures is overwriting > the initialize method (perhaps others). > > From looking into the ActiveRecord source, it seems like it would be > much less work to namespace the Fixture class inside a module than > rename our model. In addition, other users of Rails would be able to > have a "Fixture" model. I''m willing to do the work and to submit a > patch, but I wanted some advice first. Should I namespace just the > Fixture class, or should I namespace the other classes inside the > fixtures.rb file as well? Should I just put them inside of the > ActiveRecord module? > > Thanks, > Brian > ;p > > https://rails.lighthouseapp.com/projects/8994/tickets/6098-activerecord-fixture-class#ticket-6098-1 >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Hi, I''ve responded in the ticket. I agree that it should be namespaced, and if you can make a patch for it that would be really awesome. Thanks, Prem On 9 ธ.ค. 2553, at 21:21, Evgeniy Dolzhenko wrote:> I for one would expect all classes/modules in the activerecord Gem to be namespaced under ActiveRecord::* namespace. > > On 12/9/2010 5:16 PM, Brian Underwood wrote: >> Hi All, >> >> I posted a ticket to the lighthouse (link below), but I realized that >> this might be a better place for discussion of an issue. >> >> I work on a large Rails application which, unfortunately, has an >> extensively used Fixture model. Also unfortunately we just recently >> started building up our testing suite and as we''ve been trying to test >> our Fixture model, we''ve been having issues because the Fixture class >> which is used in ActiveRecord to load yaml/csv fixtures is overwriting >> the initialize method (perhaps others). >> >> From looking into the ActiveRecord source, it seems like it would be >> much less work to namespace the Fixture class inside a module than >> rename our model. In addition, other users of Rails would be able to >> have a "Fixture" model. I''m willing to do the work and to submit a >> patch, but I wanted some advice first. Should I namespace just the >> Fixture class, or should I namespace the other classes inside the >> fixtures.rb file as well? Should I just put them inside of the >> ActiveRecord module? >> >> Thanks, >> Brian >> ;p >> >> https://rails.lighthouseapp.com/projects/8994/tickets/6098-activerecord-fixture-class#ticket-6098-1 >> > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Great, then I''ll work on a patch to put all of the classes in the fixture.rb file under the ActiveRecord module Thanks, Brian ;p On Dec 9, 9:33am, Prem Sichanugrist <sikand...@gmail.com> wrote:> Hi, > > I''ve responded in the ticket. I agree that it should be namespaced, and if you can make a patch for it that would be really awesome. > > Thanks, > > Prem > > On 9 ธ.ค. 2553, at 21:21, Evgeniy Dolzhenko wrote: > > > > > I for one would expect all classes/modules in the activerecord Gem to be namespaced under ActiveRecord::* namespace. > > > On 12/9/2010 5:16 PM, Brian Underwood wrote: > >> Hi All, > > >> I posted a ticket to the lighthouse (link below), but I realized that > >> this might be a better place for discussion of an issue. > > >> I work on a large Rails application which, unfortunately, has an > >> extensively used Fixture model. Also unfortunately we just recently > >> started building up our testing suite and as we''ve been trying to test > >> our Fixture model, we''ve been having issues because the Fixture class > >> which is used in ActiveRecord to load yaml/csv fixtures is overwriting > >> the initialize method (perhaps others). > > >> From looking into the ActiveRecord source, it seems like it would be > >> much less work to namespace the Fixture class inside a module than > >> rename our model. In addition, other users of Rails would be able to > >> have a "Fixture" model. I''m willing to do the work and to submit a > >> patch, but I wanted some advice first. Should I namespace just the > >> Fixture class, or should I namespace the other classes inside the > >> fixtures.rb file as well? Should I just put them inside of the > >> ActiveRecord module? > > >> Thanks, > >> Brian > >> ;p > > >>https://rails.lighthouseapp.com/projects/8994/tickets/6098-activereco... > > > -- > > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > > For more options, visit this group athttp://groups.google.com/group/rubyonrails-core?hl=en.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.