I ran into issues using remote_function in beta4. &''s that I was trying to pass were always being escaped to & even when I passed my input string as html_safe. The code that generates the javascript is all unsafe, so the following patch fixes the issue. https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Updated patch with test... https://rails.lighthouseapp.com/projects/8994/tickets/5138-patch-fix-generated-html-for-remote_function-so-that-ampersands-can-be-used-in-passed-in-options On Sat, Jul 17, 2010 at 3:48 AM, Andrew Kaspick <akaspick@gmail.com> wrote:> I ran into issues using remote_function in beta4. &''s that I was > trying to pass were always being escaped to & even when I passed > my input string as html_safe. The code that generates the javascript > is all unsafe, so the following patch fixes the issue. > > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
I''m sure the core team is busy, but I was wondering if somebody can commit my ticket for this issue or let me know if something should be changed when you have time. I haven''t heard anything in a few days. https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 Thanks On Sat, Jul 17, 2010 at 5:03 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> Updated patch with test... > > https://rails.lighthouseapp.com/projects/8994/tickets/5138-patch-fix-generated-html-for-remote_function-so-that-ampersands-can-be-used-in-passed-in-options > > On Sat, Jul 17, 2010 at 3:48 AM, Andrew Kaspick <akaspick@gmail.com> wrote: >> I ran into issues using remote_function in beta4. &''s that I was >> trying to pass were always being escaped to & even when I passed >> my input string as html_safe. The code that generates the javascript >> is all unsafe, so the following patch fixes the issue. >> >> https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 >> >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Done! Yehuda Katz Architect | Engine Yard (ph) 718.877.1325 On Tue, Jul 20, 2010 at 7:58 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> I''m sure the core team is busy, but I was wondering if somebody can > commit my ticket for this issue or let me know if something should be > changed when you have time. I haven''t heard anything in a few days. > > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 > > Thanks > > On Sat, Jul 17, 2010 at 5:03 PM, Andrew Kaspick <akaspick@gmail.com> > wrote: > > Updated patch with test... > > > > > https://rails.lighthouseapp.com/projects/8994/tickets/5138-patch-fix-generated-html-for-remote_function-so-that-ampersands-can-be-used-in-passed-in-options > > > > On Sat, Jul 17, 2010 at 3:48 AM, Andrew Kaspick <akaspick@gmail.com> > wrote: > >> I ran into issues using remote_function in beta4. &''s that I was > >> trying to pass were always being escaped to & even when I passed > >> my input string as html_safe. The code that generates the javascript > >> is all unsafe, so the following patch fixes the issue. > >> > >> > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5138 > >> > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.