Hello, I''ve submitted a patch that tests and fixes destroy_all behavior<https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5069-activerecord-destroy_all-returns-empty-array-instead-of-destroyed-records> . The regression is that, in Rails 3, `destroy_all` always returned an empty array instead of the destroyed records. It slipped through because this behavior was never tested. I''ve added tests for master and 2-3-stable branches. It''s a particularly nasty bug in my opinion. Thanks -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Thu, Jul 8, 2010 at 5:23 AM, Mislav Marohnić <mislav.marohnic@gmail.com> wrote:> Hello, I''ve submitted a patch that tests and fixes destroy_all behavior. > The regression is that, in Rails 3, `destroy_all` always returned an empty > array instead of the destroyed records. It slipped through because this > behavior was never tested. I''ve added tests for master and 2-3-stable > branches. > It''s a particularly nasty bug in my opinion. ThanksPulled your commits. Thanks Mislav! jeremy -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.