Yury
2010-May-23 15:10 UTC
changed behavior of TranslationHelper#translate with array of keys in rails 2.3.6
Hi, I''m trying to migrate from 2.3.5 to 2.3.6.
Everything is smooth except changed behavior of
<%= t([''key1'', ''key2'']) %>
In my views I''m using join on result array:
<%= t([''key1'', ''key2'']).join('',
'') %>
after
http://github.com/rails/rails/commit/2310aef29be306704c0361f1188200f71df657df
TranslationHelper is joining array for me, why?
--
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
Santiago Pastorino
2010-May-23 19:54 UTC
Re: changed behavior of TranslationHelper#translate with array of keys in rails 2.3.6
Yeah it''s a regression please open a ticket on LightHouse and i will fix it. On Sun, May 23, 2010 at 12:10 PM, Yury <yury.korolev@gmail.com> wrote:> Hi, I''m trying to migrate from 2.3.5 to 2.3.6. > > Everything is smooth except changed behavior of > <%= t([''key1'', ''key2'']) %> > > In my views I''m using join on result array: > > <%= t([''key1'', ''key2'']).join('', '') %> > > after http://github.com/rails/rails/commit/2310aef29be306704c0361f1188200f71df657df > TranslationHelper is joining array for me, why? > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Yury Korolev
2010-May-23 20:14 UTC
Re: changed behavior of TranslationHelper#translate with array of keys in rails 2.3.6
Here is a ticket https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4675-translationhelpertranslate-joins-array Thanks. On Sun, May 23, 2010 at 11:54 PM, Santiago Pastorino <santiago@wyeworks.com>wrote:> Yeah it''s a regression please open a ticket on LightHouse and i will fix > it. > > On Sun, May 23, 2010 at 12:10 PM, Yury <yury.korolev@gmail.com> wrote: > > Hi, I''m trying to migrate from 2.3.5 to 2.3.6. > > > > Everything is smooth except changed behavior of > > <%= t([''key1'', ''key2'']) %> > > > > In my views I''m using join on result array: > > > > <%= t([''key1'', ''key2'']).join('', '') %> > > > > after > http://github.com/rails/rails/commit/2310aef29be306704c0361f1188200f71df657df > > TranslationHelper is joining array for me, why? > > > > -- > > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Santiago Pastorino
2010-May-24 03:55 UTC
Re: changed behavior of TranslationHelper#translate with array of keys in rails 2.3.6
Ok nice i will patch this. On Sun, May 23, 2010 at 5:14 PM, Yury Korolev <yury.korolev@gmail.com> wrote:> Here is a > ticket https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4675-translationhelpertranslate-joins-array > Thanks. > > On Sun, May 23, 2010 at 11:54 PM, Santiago Pastorino <santiago@wyeworks.com> > wrote: >> >> Yeah it''s a regression please open a ticket on LightHouse and i will fix >> it. >> >> On Sun, May 23, 2010 at 12:10 PM, Yury <yury.korolev@gmail.com> wrote: >> > Hi, I''m trying to migrate from 2.3.5 to 2.3.6. >> > >> > Everything is smooth except changed behavior of >> > <%= t([''key1'', ''key2'']) %> >> > >> > In my views I''m using join on result array: >> > >> > <%= t([''key1'', ''key2'']).join('', '') %> >> > >> > after >> > http://github.com/rails/rails/commit/2310aef29be306704c0361f1188200f71df657df >> > TranslationHelper is joining array for me, why? >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "Ruby on Rails: Core" group. >> > To post to this group, send email to rubyonrails-core@googlegroups.com. >> > To unsubscribe from this group, send email to >> > rubyonrails-core+unsubscribe@googlegroups.com. >> > For more options, visit this group at >> > http://groups.google.com/group/rubyonrails-core?hl=en. >> > >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.