So, I have integrated edge ActionMailer with the Mail gem, removing TMail in the process. Currently, ActionMailer is running with 131 tests, 309 assertions, 0 failures, 0 errors This is using ActionMailer from http://github.com/mikel/rails as well as the Mail gem version 1.2.8 But mail is throwing a few warnings in the process and I would love more eyes on it. I''ve done it up to here, but now I need some sanity checks :) To replicate: sudo gem install mail ( should install at least Mail 1.2.8 ) git clone git://github.com/mikel/rails.git cd rails/actionmailer rake test You should get 0 errors, 0 failures. Please let me know what you get and patches welcome!!! -- http://lindsaar.net/ Rails, RSpec and Life blog.... -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.
On Sun, Nov 22, 2009 at 5:48 AM, Mikel Lindsaar <raasdnil@gmail.com> wrote:> So, I have integrated edge ActionMailer with the Mail gem, removing TMail in > the process. > Currently, ActionMailer is running with 131 tests, 309 assertions, 0 > failures, 0 errors > This is using ActionMailer from http://github.com/mikel/rails as well as the > Mail gem version 1.2.8Which interpreters? -- Chad -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.
On Mon, Nov 23, 2009 at 10:17 AM, Chad Woolley <thewoolleyman@gmail.com>wrote:> On Sun, Nov 22, 2009 at 5:48 AM, Mikel Lindsaar <raasdnil@gmail.com> > wrote: > > So, I have integrated edge ActionMailer with the Mail gem, removing TMail > in > > the process. > > Currently, ActionMailer is running with 131 tests, 309 assertions, 0 > > failures, 0 errors > > This is using ActionMailer from http://github.com/mikel/rails as well as > the > > Mail gem version 1.2.8 > > Which interpreters? >Mail will run on Ruby 1.8.6, 1.8.7 and 1.9.1 with no spec failures My ActionMailer fork with Mail runs without error on 1.8.7. Currently we have a few failures for ActionMailer + Mail on 1.9.1, but they will be fixed soon, no big deal. Mikel -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.
KUDOS! Hell yes! - Ken On Nov 23, 2009, at 12:11 AM, Mikel Lindsaar wrote:> On Mon, Nov 23, 2009 at 10:17 AM, Chad Woolley <thewoolleyman@gmail.com> wrote: > On Sun, Nov 22, 2009 at 5:48 AM, Mikel Lindsaar <raasdnil@gmail.com> wrote: > > So, I have integrated edge ActionMailer with the Mail gem, removing TMail in > > the process. > > Currently, ActionMailer is running with 131 tests, 309 assertions, 0 > > failures, 0 errors > > This is using ActionMailer from http://github.com/mikel/rails as well as the > > Mail gem version 1.2.8 > > Which interpreters? > > Mail will run on Ruby 1.8.6, 1.8.7 and 1.9.1 with no spec failures > > My ActionMailer fork with Mail runs without error on 1.8.7. > > Currently we have a few failures for ActionMailer + Mail on 1.9.1, but they will be fixed soon, no big deal. > > Mikel > > > > > -- > > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.
On Tue, Nov 24, 2009 at 1:15 AM, Ken Collins <ken@metaskills.net> wrote:> > KUDOS! Hell yes! >Heh, thanks. So I just updated the mail gem to 1.3.0 and against my fork of actionmailer at github/mikel/rails, ActionMailer now passes all tests in MRI 1.8.6, 1.8.7 and 1.9.1 Mikel -- http://lindsaar.net/ Rails, RSpec and Life blog.... -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=.
On Mon, Nov 23, 2009 at 4:29 PM, Mikel Lindsaar <raasdnil@gmail.com> wrote:> So I just updated the mail gem to 1.3.0 and against my fork of actionmailer > at github/mikel/rails, ActionMailer now passes all tests in MRI 1.8.6, 1.8.7 > and 1.9.1Now how about JRuby? ;) -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On 25/11/2009, at 3:00, Chad Woolley <thewoolleyman@gmail.com> wrote:> On Mon, Nov 23, 2009 at 4:29 PM, Mikel Lindsaar <raasdnil@gmail.com> > wrote: >> So I just updated the mail gem to 1.3.0 and against my fork of >> actionmailer >> at github/mikel/rails, ActionMailer now passes all tests in MRI >> 1.8.6, 1.8.7 >> and 1.9.1 > > Now how about JRuby? ;)Test it and let me know :)>-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Ask and ye shall receive. So, there are 10 failures on JRuby 1.4 and a TONNE a warnings. You can see the full output here: http://gist.github.com/242667 Do you know if Carlhuda is intending on making changes in the mailer department of Rails 3? I seem to recall Yehuda mentioning something to this effect at one point. If I recall correctly it was about treating mailers like controllers. James On Nov 24, 11:50 pm, Mikel Lindsaar <raasd...@gmail.com> wrote:> On 25/11/2009, at 3:00, Chad Woolley <thewoolley...@gmail.com> wrote: > > > On Mon, Nov 23, 2009 at 4:29 PM, Mikel Lindsaar <raasd...@gmail.com> > > wrote: > >> So I just updated the mail gem to 1.3.0 and against my fork of > >> actionmailer > >> at github/mikel/rails, ActionMailer now passes all tests in MRI > >> 1.8.6, 1.8.7 > >> and 1.9.1 > > > Now how about JRuby? ;) > > Test it and let me know :) > > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
matthewrudyjacobs@gmail.com
2009-Nov-25 14:43 UTC
Re: ActionMailer with Mail gem - It is here
On Nov 25, 12:15 pm, "James H." <james.herd...@gmail.com> wrote:> Ask and ye shall receive. So, there are 10 failures on JRuby 1.4 and a > TONNE a warnings. You can see the full output here:http://gist.github.com/242667 >quite a few of those are mocha errors. missing "expects", "stubs" and such -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Wed, Nov 25, 2009 at 11:15 PM, James H. <james.herdman@gmail.com> wrote:> Ask and ye shall receive. So, there are 10 failures on JRuby 1.4 and a > TONNE a warnings. You can see the full output here: > http://gist.github.com/242667 >Thanks for the tests :) A lot of the warnings actually come from the treetop parsers'' auto generated ruby code. I''ll be cleaning up as much as I can over the coming weeks. The errors look fairly easy... most of them are probably test suite failures in terms of having these types of constructs: if RUBY_VERSION < ''1.9'' # force_encoding code else # don''t force encoding end If you could form mail, and fix up those so they run in 1.9, 1.8 and jruby and do a pull request, I would be much obliged :) Do you know if Carlhuda is intending on making changes in the mailer> department of Rails 3? I seem to recall Yehuda mentioning something to > this effect at one point. If I recall correctly it was about treating > mailers like controllers. >I was talking to Yehuda about extracting actionmailer out to allow other types of mailers, including things like IM clients etc. But from what I know, it won''t make Rails 3. Mikel -- http://lindsaar.net/ Rails, RSpec and Life blog.... -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.