ara.t.howard
2009-Apr-02 19:51 UTC
[PATCH] nested resource fields_for is fail for > one nested resource
SYNOPSIS using fields_for with a nested attribute numbers the resource index incorrectly. although this does not cause an exception it does make scripting js to add additional form elements harder and more error prone than it needs to be since the form elements generated do reflect the size of the actual association. PATCH http://gist.github.com/89383 i''m so out of the loop on rails dev i don''t know the best way to get a patch applied. please let me know if something else is needed. -a --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Eloy Duran
2009-Apr-02 20:56 UTC
Re: [PATCH] nested resource fields_for is fail for > one nested resource
Hi Ara, The patch looks great. Could you file a ticket with the same you send in this email and assign it to me? Thanks, Eloy On 2 apr 2009, at 21:51, ara.t.howard wrote:> > SYNOPSIS > using fields_for with a nested attribute numbers the resource index > incorrectly. although this does not cause an exception it does make > scripting js to add additional form elements harder and more error > prone than it needs to be since the form elements generated do reflect > the size of the actual association. > > PATCH > http://gist.github.com/89383 > > i''m so out of the loop on rails dev i don''t know the best way to get a > patch applied. please let me know if something else is needed. > > -a > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
ara.t.howard
2009-Apr-02 20:57 UTC
Re: nested resource fields_for is fail for > one nested resource
here''s a correctly formatted patch, with tests http://gist.github.com/89436 can someone give it a whack and push? cheers. -a --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
ara.t.howard
2009-Apr-02 20:58 UTC
Re: [PATCH] nested resource fields_for is fail for > one nested resource
On Apr 2, 2:56 pm, Eloy Duran <eloy.de.en...@gmail.com> wrote:> Hi Ara, > > The patch looks great. > Could you file a ticket with the same you send in this email and > assign it to me? > > Thanks, > Eloywe crossed paths - yes i''ll create a ticket too. thanks!> > On 2 apr 2009, at 21:51, ara.t.howard wrote: > > > > > SYNOPSIS > > using fields_for with a nested attribute numbers the resource index > > incorrectly. although this does not cause an exception it does make > > scripting js to add additional form elements harder and more error > > prone than it needs to be since the form elements generated do reflect > > the size of the actual association. > > > PATCH > > http://gist.github.com/89383 > > > i''m so out of the loop on rails dev i don''t know the best way to get a > > patch applied. please let me know if something else is needed. > > > -a--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
ara.t.howard
2009-Apr-02 21:12 UTC
Re: [PATCH] nested resource fields_for is fail for > one nested resource
On Apr 2, 2:56 pm, Eloy Duran <eloy.de.en...@gmail.com> wrote:> Hi Ara, > > The patch looks great. > Could you file a ticket with the same you send in this email and > assign it to me? > > Thanks, > Eloyhttps://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2401> > On 2 apr 2009, at 21:51, ara.t.howard wrote: > > > > > SYNOPSIS > > using fields_for with a nested attribute numbers the resource index > > incorrectly. although this does not cause an exception it does make > > scripting js to add additional form elements harder and more error > > prone than it needs to be since the form elements generated do reflect > > the size of the actual association. > > > PATCH > > http://gist.github.com/89383 > > > i''m so out of the loop on rails dev i don''t know the best way to get a > > patch applied. please let me know if something else is needed. > > > -a--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---