The 2.3 release notes have this:> 4.8 Hash Conditions for has_many relationships > You can once again use a hash in conditions for a has_many relationship: > > has_many :orders, :conditions => {:status => ''confirmed''} > That worked in Rails 2.1, fails in Rails 2.2, and will now work again in Rails 2.3 (if you’re dealing with this issue in Rails 2.2, you can use a string rather than a hash to specify conditions). > > Lead Contributor: Frederick CheungI can''t see the commit for this. There was an issue that broke them (with eager loading) in 2.1, but it got fixed in 2.2, not 2.3; is this a second, separate issue? Cheers, Will --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> I can''t see the commit for this. There was an issue that broke them > (with eager loading) in 2.1, but it got fixed in 2.2, not 2.3; is this > a second, separate issue?I can''t actually see this either, Mike any idea what commit that''s referring too? Or fred maybe? -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Tracking the history of that paragraph back, it points to http://github.com/rails/rails/commit/b17b9371c6a26484eb1984d45acffcdcd91b1ae1 which in turn claims to come from http://rails.lighthouseapp.com/projects/8994/tickets/1461 which is where the description originates. Looks to me like probably the release notes should be clarified. Mike On Mar 9, 2009, at 2:20 AM, Michael Koziarski wrote:>> I can''t see the commit for this. There was an issue that broke them >> (with eager loading) in 2.1, but it got fixed in 2.2, not 2.3; is >> this >> a second, separate issue? > > I can''t actually see this either, Mike any idea what commit that''s > referring too? Or fred maybe? > > -- > Cheers > > Koz--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---