Jordi Bunster
2009-Mar-06 16:01 UTC
[PATCH] GitHub :author param to config.gem (Rails::GemDependency)
Lately my environment.rb is filled with GitHub gems. I suspect yours is too. I got a bit tired of all the :source and :lib stuff, so I whipped this patch to allow me to pass :author => ''foo''. It then changes the defaults for :lib and :source (as well as changes the gem name), to fit what GitHub expects. If you''re interested, please test and +1 at http://rails.lighthouseapp.com/projects/8994/tickets/2152 -- Jordi
Niels Ganser
2009-Mar-06 20:43 UTC
Re: [PATCH] GitHub :author param to config.gem (Rails::GemDependency)
I like the idea. I''d prefer :prefix or :prepend over :author though as Damian mentioned on lighhouse. However, I also agree with Pratik when it comes to putting service specific code into Rails core. Would it be possible to not explicitly specify gems.github.com as the source and let rubygems handle this? When using the gems CLI this works.. Best, Niels Jordi Bunster wrote:> Lately my environment.rb is filled with GitHub gems. I suspect yours > is too. > > I got a bit tired of all the :source and :lib stuff, so I whipped this > patch to allow me to pass :author => ''foo''. It then changes the > defaults for :lib and :source (as well as changes the gem name), to > fit what GitHub expects. > > If you''re interested, please test and +1 at > http://rails.lighthouseapp.com/projects/8994/tickets/2152 > > -- > > Jordi >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
MatthewRudy
2009-Mar-07 11:48 UTC
Re: GitHub :author param to config.gem (Rails::GemDependency)
It feels like a plugin. config.github_gem "nowayout", :author => "pdiddy" as a wrapper around config.gem which gets you what you want. On Mar 6, 4:01 pm, Jordi Bunster <jo...@bunster.org> wrote:> Lately my environment.rb is filled with GitHub gems. I suspect yours > is too. > > I got a bit tired of all the :source and :lib stuff, so I whipped this > patch to allow me to pass :author => ''foo''. It then changes the > defaults for :lib and :source (as well as changes the gem name), to > fit what GitHub expects. > > If you''re interested, please test and +1 athttp://rails.lighthouseapp.com/projects/8994/tickets/2152 > > -- > > Jordi > > smime.p7s > 2KViewDownload--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Jordi Bunster
2009-Mar-09 18:05 UTC
Re: GitHub :author param to config.gem (Rails::GemDependency)
I have it working like that here, but in a pre-initializer. I suspect it''s not possible to do as a plugin, because they get loaded after that step. On Sat, Mar 7, 2009 at 7:48 AM, MatthewRudy <matthewrudyjacobs@gmail.com> wrote:> > It feels like a plugin. > > config.github_gem "nowayout", :author => "pdiddy" > > as a wrapper around config.gem which gets you what you want.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---