Rails core - Feb 2009 - PATCH Make named_scopes remember the current scope when defined

Hi there,

I''ve submitted a patch a few days ago and now it has 3 positive votes
on lighthouse. Would love some more reviews.
http://rails.lighthouseapp.com/projects/8994/tickets/1960-make-named_scopes-remember-the-current-scope-when-defined

The patch is about named_scopes not remembering previously setted
scopes (like from a has_many assoc) when executed.

Thanks
-- 
Diego Algorta
http://www.oboxodo.com - http://diego.algorta.net

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On Fri, Feb 20, 2009 at 10:39 AM, Diego Algorta Casamayou
<diego.algorta@gmail.com> wrote:
> Hi there,
>
> I''ve submitted a patch a few days ago and now it has 3 positive
votes
> on lighthouse. Would love some more reviews.
>
http://rails.lighthouseapp.com/projects/8994/tickets/1960-make-named_scopes-remember-the-current-scope-when-defined
>
> The patch is about named_scopes not remembering previously setted
> scopes (like from a has_many assoc) when executed.
It would be great if this patch gets merged before 2.3 gets released.
Anyone from the core able to review?

Thanks,
-- 
Diego Algorta
http://www.oboxodo.com - http://diego.algorta.net

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On Wed, Feb 25, 2009 at 2:11 PM, Diego Algorta Casamayou
<diego.algorta@gmail.com> wrote:
> On Fri, Feb 20, 2009 at 10:39 AM, Diego Algorta Casamayou
> <diego.algorta@gmail.com> wrote:
>> Hi there,
>>
>> I''ve submitted a patch a few days ago and now it has 3
positive votes
>> on lighthouse. Would love some more reviews.
>>
http://rails.lighthouseapp.com/projects/8994/tickets/1960-make-named_scopes-remember-the-current-scope-when-defined
>>
>> The patch is about named_scopes not remembering previously setted
>> scopes (like from a has_many assoc) when executed.
>
> It would be great if this patch gets merged before 2.3 gets released.
> Anyone from the core able to review?
Thanks rich!
http://github.com/rails/rails/commit/0dd2f96f5c90f8abacb0fe0757ef7e5db4a4d501

Applied.

-- 
Diego Algorta
http://www.oboxodo.com - http://diego.algorta.net

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---