Greg Borenstein
2009-Jan-19 21:12 UTC
The Tiniest Patch in the World [review request] OrderedHash should not pretend to be an Array #1782
I just submitted The Tiniest Patch in the World. This patch adds an #inspect method to ActiveSupport::OrderedHash to make the display of OrderedHashes more obvious in order to avoid confusion of them with Arrays (which their current #inspect makes them appear to resemble). Here is the patch on Lighthouse: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1782-orderedhash-should-not-pretend-to-be-an-array And here is a pastie with some example output: http://pastie.org/364930 Output format was developed in conversation with technoweenie on The Twitter. Thanks, in advance, Greg Borenstein http://urbanhonking.com/ideasfordozens --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Josh Susser
2009-Jan-19 22:14 UTC
Re: The Tiniest Patch in the World [review request] OrderedHash should not pretend to be an Array #1782
Tiniest patch? I think not! 1 char, plus tests: http://dev.rubyonrails.org/changeset/7361 :-) --josh On Jan 19, 2009, at 1:12 PM, Greg Borenstein wrote:> > I just submitted The Tiniest Patch in the World. This patch adds an > #inspect method to ActiveSupport::OrderedHash to make the display of > OrderedHashes more obvious in order to avoid confusion of them with > Arrays (which their current #inspect makes them appear to resemble). > Here is the patch on Lighthouse: > > http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1782-orderedhash-should-not-pretend-to-be-an-array > > And here is a pastie with some example output: > > http://pastie.org/364930 > > Output format was developed in conversation with technoweenie on The > Twitter. > > Thanks, in advance, > > Greg Borenstein > http://urbanhonking.com/ideasfordozens > > > > > >-- Josh Susser http://blog.hasmanythrough.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---