I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and related commits that the extensions to TestCase are getting pulled out; what''s the correct thing to put into test/test_helper.rb? --Matt Jones --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Mon, Nov 17, 2008 at 10:31 AM, Matt Jones <al2o3cr@gmail.com> wrote:> > I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and related > commits that > the extensions to TestCase are getting pulled out; what''s the correct > thing to put into test/test_helper.rb?Use ActiveSupport::TestCase instead of Test::Unit::TestCase :) jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Are you sure? When I changed that (in test/test_helper.rb), none of the test methods ran, and I don''t see any activity in the log. On Nov 17, 2008, at 1:41 PM, Jeremy Kemper wrote:> > On Mon, Nov 17, 2008 at 10:31 AM, Matt Jones <al2o3cr@gmail.com> > wrote: >> >> I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and related >> commits that >> the extensions to TestCase are getting pulled out; what''s the correct >> thing to put into test/test_helper.rb? > > Use ActiveSupport::TestCase instead of Test::Unit::TestCase :) > > jeremy > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Just so you know, I have edge frozen from around five days ago and I went through and replaced all Test::Unit::TestCase instances in my test/ directory and all my tests still pass. On Nov 17, 2008, at 11:31 AM, Matt Jones wrote:> > Are you sure? When I changed that (in test/test_helper.rb), none of > the test methods ran, and I > don''t see any activity in the log. > > On Nov 17, 2008, at 1:41 PM, Jeremy Kemper wrote: > >> >> On Mon, Nov 17, 2008 at 10:31 AM, Matt Jones <al2o3cr@gmail.com> >> wrote: >>> >>> I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and related >>> commits that >>> the extensions to TestCase are getting pulled out; what''s the >>> correct >>> thing to put into test/test_helper.rb? >> >> Use ActiveSupport::TestCase instead of Test::Unit::TestCase :) >> >> jeremy >> >>> > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Found it - in activesupport/lib/active_support/test_case.rb, test/unit needs to be required, or the tests don''t get run. Add "require ''test/unit''" after "rescue LoadError". --Matt On Nov 17, 2008, at 3:46 PM, Kevin Hall wrote:> > Just so you know, I have edge frozen from around five days ago and I > went through and replaced all Test::Unit::TestCase instances in my > test/ directory and all my tests still pass. > > On Nov 17, 2008, at 11:31 AM, Matt Jones wrote: > >> >> Are you sure? When I changed that (in test/test_helper.rb), none of >> the test methods ran, and I >> don''t see any activity in the log. >> >> On Nov 17, 2008, at 1:41 PM, Jeremy Kemper wrote: >> >>> >>> On Mon, Nov 17, 2008 at 10:31 AM, Matt Jones <al2o3cr@gmail.com> >>> wrote: >>>> >>>> I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and >>>> related >>>> commits that >>>> the extensions to TestCase are getting pulled out; what''s the >>>> correct >>>> thing to put into test/test_helper.rb? >>> >>> Use ActiveSupport::TestCase instead of Test::Unit::TestCase :) >>> >>> jeremy >>> >>>> >> >> >>> > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Mon, Nov 17, 2008 at 1:26 PM, Matt Jones <al2o3cr@gmail.com> wrote:> Found it - in activesupport/lib/active_support/test_case.rb, test/unit > needs to be required, > or the tests don''t get run. Add "require ''test/unit''" after "rescue > LoadError".It''s required in railties'' test_help. Otherwise, requiring ''active_support/test_case'' will tests even if you didn''t mean to. jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
The relevant line (from railties test_help.rb) was deleted in commit 582aa2ead58eacffca13e7efe94235958ee4db1b on November 7 - should that be put back? --Matt On Nov 17, 2008, at 4:39 PM, Jeremy Kemper wrote:> > On Mon, Nov 17, 2008 at 1:26 PM, Matt Jones <al2o3cr@gmail.com> wrote: >> Found it - in activesupport/lib/active_support/test_case.rb, test/ >> unit >> needs to be required, >> or the tests don''t get run. Add "require ''test/unit''" after "rescue >> LoadError". > > It''s required in railties'' test_help. > > Otherwise, requiring ''active_support/test_case'' will tests even if you > didn''t mean to. > > jeremy > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Yes; thanks: 5a4789e :) jeremy On Mon, Nov 17, 2008 at 2:03 PM, Matt Jones <al2o3cr@gmail.com> wrote:> > The relevant line (from railties test_help.rb) was deleted in commit > 582aa2ead58eacffca13e7efe94235958ee4db1b > on November 7 - should that be put back? > > --Matt > > On Nov 17, 2008, at 4:39 PM, Jeremy Kemper wrote: > >> >> On Mon, Nov 17, 2008 at 1:26 PM, Matt Jones <al2o3cr@gmail.com> wrote: >>> Found it - in activesupport/lib/active_support/test_case.rb, test/ >>> unit >>> needs to be required, >>> or the tests don''t get run. Add "require ''test/unit''" after "rescue >>> LoadError". >> >> It''s required in railties'' test_help. >> >> Otherwise, requiring ''active_support/test_case'' will tests even if you >> didn''t mean to. >> >> jeremy >> >> > > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---