Hi all, Just sending this email to keep you guys in the loop as Rails 2.2 RC1 release is imminent. After the RC1 is release, no new features will be committed to the 2.2 branch and the API will be frozen as well. It''ll all be about bug fixes then. So before 2.2.RC1 is pushed, if you think any features should make it in, please let your voices be heard. Same goes for any critical bug fixes. If you have any pending patches that you want in 2.2, speak now. Thanks. -- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Oct 6, 2008, at 6:38 PM, Pratik wrote:> If you have any pending patches that you want in 2.2, speak > now.It would be awesome if you could take a look at: #1179 [1]. Manfred [1] http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1179-fix-a-small-typo-in-multibyte --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Mon, Oct 6, 2008 at 6:58 PM, Manfred Stienstra <manfred@gmail.com> wrote:> It would be awesome if you could take a look at: #1179 [1].Pushed. -- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 6 Oct 2008, at 17:38, Pratik wrote:> > Hi all, > > Just sending this email to keep you guys in the loop as Rails 2.2 RC1 > release is imminent. After the RC1 is release, no new features will be > committed to the 2.2 branch and the API will be frozen as well. It''ll > all be about bug fixes then. > > So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now. >There are a number of tickets to do with :include from a variety of people that at least deserve a look at. I''ll dig em up Fred> Thanks. > > -- > Cheers! > - Pratik > http://m.onkey.org > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Tue, Oct 7, 2008 at 5:38 AM, Pratik <pratiknaik@gmail.com> wrote:> So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now. >My patch on #1110, please. It''s a regression introduced in 2.1, and the patch is fairly straightforward. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Hi Pratik Could we get this one in http://rails.lighthouseapp.com/projects/8994/tickets/1085-asset_tag_helperrb-expression-bug-in-compute_public_path Small bug fix for image_tag generating a bad URL when running on Windows. cheers madlep On Oct 7, 3:38 am, Pratik <pratikn...@gmail.com> wrote:> Hi all, > > Just sending this email to keep you guys in the loop as Rails 2.2 RC1 > release is imminent. After the RC1 is release, no new features will be > committed to the 2.2 branch and the API will be frozen as well. It''ll > all be about bug fixes then. > > So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now. > > Thanks. > > -- > Cheers! > - Pratikhttp://m.onkey.org--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I posted this here last Monday and it''s small... http://rails.lighthouseapp.com/projects/8994/tickets/1146-use-name-for-select_tag-when-using-multiple-true#ticket-1146-1 Thanks On Mon, Oct 6, 2008 at 5:32 PM, madlep <julian.doherty.ml@gmail.com> wrote:> > Hi Pratik > > Could we get this one in > http://rails.lighthouseapp.com/projects/8994/tickets/1085-asset_tag_helperrb-expression-bug-in-compute_public_path > > Small bug fix for image_tag generating a bad URL when running on > Windows. > > cheers > madlep > > On Oct 7, 3:38 am, Pratik <pratikn...@gmail.com> wrote: >> Hi all, >> >> Just sending this email to keep you guys in the loop as Rails 2.2 RC1 >> release is imminent. After the RC1 is release, no new features will be >> committed to the 2.2 branch and the API will be frozen as well. It''ll >> all be about bug fixes then. >> >> So before 2.2.RC1 is pushed, if you think any features should make it >> in, please let your voices be heard. Same goes for any critical bug >> fixes. If you have any pending patches that you want in 2.2, speak >> now. >> >> Thanks. >> >> -- >> Cheers! >> - Pratikhttp://m.onkey.org > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 6 Oct 2008, at 23:14, Will Bryant wrote:> On Tue, Oct 7, 2008 at 5:38 AM, Pratik <pratiknaik@gmail.com> wrote: > So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now. > > My patch on #1110, please. It''s a regression introduced in 2.1, and > the patch is fairly straightforward. >That was one i was thinking of. Another was http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1104-references_eager_loaded_tables-should-search-tables-in-join-clauses#ticket-1104-2 which turns out not to have a patch yet. Finally, a small patch of my own: http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-select-with-include.patch (which personally I mostly want because I''ve been working on making :include of hmt a bit leaner and need that patch to cover all cases) Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Tue, Oct 7, 2008 at 12:18 PM, Frederick Cheung < frederick.cheung@gmail.com> wrote:> Finally, a small patch of my own: > http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-select-with-include.patch > (which personally I mostly want because I''ve been working on > making :include of hmt a bit leaner and need that patch to cover all > cases) >Applying this makes it possible to fix the #1110 issue for HABTM also (otherwise it''s fixed for everything but HABTM) - I''ve attached a second patch to #1110 for that. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Hey guys, This is not a Rails 2.2 issue, but would love to see this fixed in the official exception_notification git repos: http://rails.lighthouseapp.com/projects/8995/tickets/35 Basically just so that the edge version of the exception_notification plugin will work with Rails 2.2RC. If it helps, it''s a very trivial fix :) Cheers, Chu Yeow On Tue, Oct 7, 2008 at 8:57 AM, Will Bryant <will.bryant@gmail.com> wrote:> On Tue, Oct 7, 2008 at 12:18 PM, Frederick Cheung < > frederick.cheung@gmail.com> wrote: > >> Finally, a small patch of my own: >> http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-select-with-include.patch >> (which personally I mostly want because I''ve been working on >> making :include of hmt a bit leaner and need that patch to cover all >> cases) >> > > Applying this makes it possible to fix the #1110 issue for HABTM also > (otherwise it''s fixed for everything but HABTM) - I''ve attached a second > patch to #1110 for that. > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now.There is also this small enhancement that adds support for index length in MySQL adapter and schema dumper: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/734 -- Jonathan Weiss http://blog.innerewut.de http://twitter.com/jweiss --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now.The patch included in #1011 [1] fixes a bug introduced into Active Resource when dealing with nested resources. [1] http://rails.lighthouseapp.com/projects/8994/tickets/1011-re-add-to_xml-to-activeresource#ticket-1011-6 -- Cody Fauser http://shopify.com - e-commerce done right http://www.codyfauser.com - blog http://peepcode.com/products/activemerchant-pdf - ActiveMerchant PeepCode http://www.oreilly.com/catalog/rjsrails - RJS Templates for Rails --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Hey Chu Yeow, I pushed that. The plugin still seems broken on the edge. Thanks. On Tue, Oct 7, 2008 at 8:16 AM, Cheah Chu Yeow <chuyeow@gmail.com> wrote:> Hey guys, > This is not a Rails 2.2 issue, but would love to see this fixed in the > official exception_notification git repos: > http://rails.lighthouseapp.com/projects/8995/tickets/35 > > Basically just so that the edge version of the exception_notification plugin > will work with Rails 2.2RC. > If it helps, it''s a very trivial fix :) > Cheers, > Chu Yeow > > > On Tue, Oct 7, 2008 at 8:57 AM, Will Bryant <will.bryant@gmail.com> wrote: >> >> On Tue, Oct 7, 2008 at 12:18 PM, Frederick Cheung >> <frederick.cheung@gmail.com> wrote: >>> >>> Finally, a small patch of my own: >>> http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-select-with-include.patch >>> (which personally I mostly want because I''ve been working on >>> making :include of hmt a bit leaner and need that patch to cover all >>> cases) >> >> Applying this makes it possible to fix the #1110 issue for HABTM also >> (otherwise it''s fixed for everything but HABTM) - I''ve attached a second >> patch to #1110 for that. >> > > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Thanks Pratik. Oops, I am not Rails edge but I kinda assumed the Object#send! bug was the only problem. I''m having problems running on edge Rails at the moment due weird database disconnection bugs after the connection pooling patch. If I do manage to upgrade any of my apps to edge (I''ll try the RC at the least), I''ll be sure to send in a patch to exception_notification if necessary :) On Tue, Oct 7, 2008 at 7:15 PM, Pratik <pratiknaik@gmail.com> wrote:> > Hey Chu Yeow, > > I pushed that. The plugin still seems broken on the edge. > > Thanks. > > On Tue, Oct 7, 2008 at 8:16 AM, Cheah Chu Yeow <chuyeow@gmail.com> wrote: > > Hey guys, > > This is not a Rails 2.2 issue, but would love to see this fixed in the > > official exception_notification git repos: > > http://rails.lighthouseapp.com/projects/8995/tickets/35 > > > > Basically just so that the edge version of the exception_notification > plugin > > will work with Rails 2.2RC. > > If it helps, it''s a very trivial fix :) > > Cheers, > > Chu Yeow > > > > > > On Tue, Oct 7, 2008 at 8:57 AM, Will Bryant <will.bryant@gmail.com> > wrote: > >> > >> On Tue, Oct 7, 2008 at 12:18 PM, Frederick Cheung > >> <frederick.cheung@gmail.com> wrote: > >>> > >>> Finally, a small patch of my own: > >>> > http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-select-with-include.patch > >>> (which personally I mostly want because I''ve been working on > >>> making :include of hmt a bit leaner and need that patch to cover all > >>> cases) > >> > >> Applying this makes it possible to fix the #1110 issue for HABTM also > >> (otherwise it''s fixed for everything but HABTM) - I''ve attached a second > >> patch to #1110 for that. > >> > > > > > > > > > > > > > -- > Cheers! > - Pratik > http://m.onkey.org > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
У Аўт, 07/10/2008 у 19:21 +0800, Cheah Chu Yeow піша:> I''m having problems running on edge Rails at the moment due weird > database disconnection bugs after the connection pooling patch. If I > do manage to upgrade any of my apps to edge (I''ll try the RC at the > least), I''ll be sure to send in a patch to exception_notification if > necessary :) >Connection pool bugs should be resolved now. BTW, I upgraded to edge last thursday and had to fix only send! in exception_notification. -- Aliaksey Kandratsenka <alkondratenko@gmail.com> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Hey Andrew, I''ve pushed that with some minor changes. Thanks. On Mon, Oct 6, 2008 at 11:37 PM, Andrew Kaspick <akaspick@gmail.com> wrote:> > I posted this here last Monday and it''s small... > > http://rails.lighthouseapp.com/projects/8994/tickets/1146-use-name-for-select_tag-when-using-multiple-true#ticket-1146-1 > > Thanks > > On Mon, Oct 6, 2008 at 5:32 PM, madlep <julian.doherty.ml@gmail.com> wrote: >> >> Hi Pratik >> >> Could we get this one in >> http://rails.lighthouseapp.com/projects/8994/tickets/1085-asset_tag_helperrb-expression-bug-in-compute_public_path >> >> Small bug fix for image_tag generating a bad URL when running on >> Windows. >> >> cheers >> madlep >> >> On Oct 7, 3:38 am, Pratik <pratikn...@gmail.com> wrote: >>> Hi all, >>> >>> Just sending this email to keep you guys in the loop as Rails 2.2 RC1 >>> release is imminent. After the RC1 is release, no new features will be >>> committed to the 2.2 branch and the API will be frozen as well. It''ll >>> all be about bug fixes then. >>> >>> So before 2.2.RC1 is pushed, if you think any features should make it >>> in, please let your voices be heard. Same goes for any critical bug >>> fixes. If you have any pending patches that you want in 2.2, speak >>> now. >>> >>> Thanks. >>> >>> -- >>> Cheers! >>> - Pratikhttp://m.onkey.org >> >> > >> > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Cody : Patch is missing documentation. Fred : Let''s handle that :select issue post 2.2 Thanks. -- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Pratik, I updated the current patch with some additional documentation. On Tue, Oct 7, 2008 at 10:38 AM, Pratik <pratiknaik@gmail.com> wrote:> > Cody : Patch is missing documentation. > > Fred : Let''s handle that :select issue post 2.2 > > Thanks. > -- > Cheers! > - Pratik > http://m.onkey.org > > > >-- Cody Fauser http://shopify.com - e-commerce done right http://www.codyfauser.com - blog http://peepcode.com/products/activemerchant-pdf - ActiveMerchant PeepCode http://www.oreilly.com/catalog/rjsrails - RJS Templates for Rails --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
If possible, I would like to see #1083[1] committed. It make calls to private methods on association proxies consistent with the behavior added in #1084[2], which was committed on 24 September. Thanks, Adam [1] http://rails.lighthouseapp.com/projects/8994/tickets/1083-calls-to-private-methods-via-association-proxies-should-act-consistently-with-ruby-method-dispatch [2] http://rails.lighthouseapp.com/projects/8994/tickets/1084-activerecord-attributes-should-respect-access-control On Oct 6, 9:38 am, Pratik <pratikn...@gmail.com> wrote:> Hi all, > > Just sending this email to keep you guys in the loop as Rails 2.2 RC1 > release is imminent. After the RC1 is release, no new features will be > committed to the 2.2 branch and the API will be frozen as well. It''ll > all be about bug fixes then. > > So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now. > > Thanks. > > -- > Cheers! > - Pratikhttp://m.onkey.org--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I''ve given up trying to patch the first one Frederick Cheung wanted (1104-references_eager_loaded_tables-should-search-tables-in-join- clauses), in favor of this approach: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1185-old-single-query-includes-should-be-globally-disableable Patch and doc is submitted, can we get this reviewed/committed? -David Stevenson On Oct 6, 4:18 pm, Frederick Cheung <frederick.che...@gmail.com> wrote:> On 6 Oct 2008, at 23:14, Will Bryant wrote: > > > On Tue, Oct 7, 2008 at 5:38 AM, Pratik <pratikn...@gmail.com> wrote: > > So before 2.2.RC1 is pushed, if you think any features should make it > > in, please let your voices be heard. Same goes for any critical bug > > fixes. If you have any pending patches that you want in 2.2, speak > > now. > > > My patch on #1110, please. It''s a regression introduced in 2.1, and > > the patch is fairly straightforward. > > That was one i was thinking of. Another washttp://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/11... > which turns out not to have a patch yet. > > Finally, a small patch of my own:http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-s... > (which personally I mostly want because I''ve been working on > making :include of hmt a bit leaner and need that patch to cover all > cases) > > Fred--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I have also one patch related to exception_notification plugin.
Since Rails 2.2 is about localization, more people are likely to
override rescue_action_in_public in Controllers to show localized
rescues, which leads to an error in exception_notification.
The patch also fix the problem that exception_notification has the
public directory hard coded "#{RAILS_ROOT}/public/404.html".
http://rails.lighthouseapp.com/projects/8995/tickets/16-exception-notifiable-should-not-override-rescue_action_in_public
Thanks!
http://josevalim.blogspot.com/
http://www.pagestacker.com/
On Oct 9, 2:37 pm, David Stevenson <dsboul...@gmail.com>
wrote:> I''ve given up trying to patch the first one Frederick Cheung
wanted
> (1104-references_eager_loaded_tables-should-search-tables-in-join-
> clauses), in favor of this approach:
>
> http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/11...
>
> Patch and doc is submitted, can we get this reviewed/committed?
>
> -David Stevenson
>
> On Oct 6, 4:18 pm, Frederick Cheung <frederick.che...@gmail.com>
> wrote:
>
> > On 6 Oct 2008, at 23:14, Will Bryant wrote:
>
> > > On Tue, Oct 7, 2008 at 5:38 AM, Pratik
<pratikn...@gmail.com> wrote:
> > > So before 2.2.RC1 is pushed, if you think any features should
make it
> > > in, please let your voices be heard. Same goes for any critical
bug
> > > fixes. If you have any pending patches that you want in 2.2,
speak
> > > now.
>
> > > My patch on #1110, please. It''s a regression introduced
in 2.1, and
> > > the patch is fairly straightforward.
>
> > That was one i was thinking of. Another
washttp://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/11...
> > which turns out not to have a patch yet.
>
> > Finally, a small patch of my
own:http://rails.lighthouseapp.com/attachments/46336/0001-enable-use-of-s...
> > (which personally I mostly want because I''ve been working on
> > making :include of hmt a bit leaner and need that patch to cover all
> > cases)
>
> > Fred
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
On Oct 6, 2008, at 12:38 PM, Pratik wrote:> So before 2.2.RC1 is pushed, if you think any features should make it > in, please let your voices be heard. Same goes for any critical bug > fixes. If you have any pending patches that you want in 2.2, speak > now.This is really tiny. It might seem silly, but it makes merging schema.rb a bit quicker. http://github.com/jordi/rails/tree/readable_schema_rb_timestamp (also attached) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~--- -- Jordi