rogerdpack
2008-Sep-16 16:51 UTC
Are there places where could improve error reporting [aesthetic wise]?
Hi. I submitted a patch [1] which adds some coloration to actionpack-2.1.0/lib/action_controller/templates/rescues/layout.erb and was wondering if there are any other places besides it that could also use improved error reporting/coloration. Thoughts? Thanks! -=Roger Pack [1] http://rails.lighthouseapp.com/projects/8994/tickets/249-better-coloration-on-error-messages --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Michael Koziarski
2008-Sep-17 09:06 UTC
Re: Are there places where could improve error reporting [aesthetic wise]?
> Hi. I submitted a patch [1] which adds some coloration to > actionpack-2.1.0/lib/action_controller/templates/rescues/layout.erb > > and was wondering if there are any other places besides it that could > also use improved error reporting/coloration. > > Thoughts?A nicer error page would certainly be great to have, and this is a good start. Perhaps the easiest way for people to give feedback would be to stick up some static HTML somewhere, and people can comment based on that. There are a few minor issues such as inline styles vs class declarations, but those can be addressed once there''s something concrete to include. If there''s more information which may be useful, then feel free to include those in the static html too. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
rogerdpack
2008-Oct-01 20:35 UTC
Re: Are there places where could improve error reporting [aesthetic wise]?
Here is an example of what the current patch does. Any feedback? -=R http://wilkboardonline.com/roger/latest.html> A nicer error page would certainly be great to have, and this is a > good start. Perhaps the easiest way for people to give feedback would > be to stick up some static HTML somewhere, and people can comment > based on that. There are a few minor issues such as inline styles vs > class declarations, but those can be addressed once there''s something > concrete to include. > > If there''s more information which may be useful, then feel free to > include those in the static html too.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Michael Koziarski
2008-Oct-04 11:43 UTC
Re: Are there places where could improve error reporting [aesthetic wise]?
rogerdpack wrote:> Here is an example of what the current patch does. > Any feedback? > -=R > http://wilkboardonline.com/roger/latest.htmlThis is a fairly subtle change and to be honest I didn''t even notice it at first. My advice would be to rethink the design a little more and make some changes. Once you''ve made them you then should document each of them and why you made them, this will help others give you some feedback. Don''t feel constrained too much by the existing layout. If there''s room to improve it then feel free to do so. -- Cheers, Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---