Hey folks, Line 725 of actionpack/lib/action_view/helpers/prototype_helper.rb, the insert_html method, uses Insertion, which seems to be deprecated in Prototype as of Prototype 1.6: http://www.prototypejs.org/api/insertion Should it use Element.insert instead? Thanks, Dan --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Mislav Marohnić
2008-Mar-11 10:57 UTC
Re: prototype_helper.rb''s insert_html using Insertion
On Tue, Mar 11, 2008 at 6:24 AM, Dan Croak <dcroak@thoughtbot.com> wrote:> > Should it use Element.insert instead?Yes. Anyone helping out with updating/cleaning up javascript helpers in ActionView is welcome. If you can''t do it yourself for some reason, open up a ticket for this (search for older tickets just in case) and link to it from this thread. Let''s nudge this in the right direction. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Okay, I''ll do it one evening this week. On Mar 11, 6:57 am, "Mislav Marohnić" <mislav.maroh...@gmail.com> wrote:> Yes. Anyone helping out with updating/cleaning up javascript helpers in > ActionView is welcome. > > Let''s nudge this in the right direction.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Just created a ticket: http://dev.rubyonrails.org/ticket/11401 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---