Murray Steele
2008-Feb-14 10:14 UTC
ActiveRecord migration_test fix + sqlserver adapter tests patch
Hi all, Whilst trying to make the sqlserver adapter tests work with the changes made in [8681] I noticed an incorrect test (test_rename_column_with_an_index) in ar/test/cases/migration_test. I created a tiny wee patch to fix the test and would appreciate some +1s. http://dev.rubyonrails.org/ticket/11105 Also, there''s an only slightly bigger patch to fix up the sqlserver adpater tests to work again and I''d love some +1s on that too, but I appreciate that the sqlserver adapter is less commonly used,s o I''m not holding my breath on this one. http://dev.rubyonrails.org/ticket/11106 Cheers, Murray --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Lawrence Pit
2008-Feb-14 10:47 UTC
Re: ActiveRecord migration_test fix + sqlserver adapter tests patch
Thanks Murray. It''s committed. Cheers, Lawrence> Also, there''s an only slightly bigger patch to fix up the sqlserver > adpater tests to work again and I''d love some +1s on that too, but I > appreciate that the sqlserver adapter is less commonly used,s o I''m > not holding my breath on this one. http://dev.rubyonrails.org/ticket/11106 > > Cheers, > > Murray--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Wil Chung
2008-Feb-14 20:18 UTC
Re: ActiveRecord migration_test fix + sqlserver adapter tests patch
Hi all, I have a small enhancement to actioncontroller that I''d like reviewed. It''s a before_filter that respond_to different mime types. http://dev.rubyonrails.org/ticket/11118 I have added tests and documentation too. Please review it, and if it''s to your liking +1 it. Otherwise, let me know what else I''d need to do to get it committable. Thanks. Wilhelm -- http://webjazz.blogspot.com http://www.mobtropolis.com http://www.3cglabs.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---