Hopefully, this is a little less contentious! As the description in the ticket states: "In edge nested resources have a default :name_prefix which doesn''t exist in 1-2-stable. The attached patch adds the :name_prefix for nested resources without an explicit :name_prefix and deprecates the old names. The patch changes some existing tests to add the :name_prefix so that they will pass and add some new tests that check for the existence of the old named routes and that they are deprecated." BTW, I am correct in assuming that singleton resources shouldn''t have collection actions? I noticed in edge and stable that map_collection_actions is called in map_singleton_resource. It doesn''t choke if you pass :collection to map.resource but they end up with the same names as member actions. Andrew White --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> "In edge nested resources have a default :name_prefix which doesn''t > exist in 1-2-stable. The attached patch adds the :name_prefix for > nested resources without an explicit :name_prefix and deprecates the > old names. The patch changes some existing tests to add > the :name_prefix so that they will pass and add some new tests that > check for the existence of the old named routes and that they are > deprecated."Sounds good to me.> BTW, I am correct in assuming that singleton resources shouldn''t have > collection actions? I noticed in edge and stable that > map_collection_actions is called in map_singleton_resource. It > doesn''t choke if you pass :collection to map.resource but they end up > with the same names as member actions.Yeah, that sounds like a mistake. Shouldn''t be creating stuff that''ll get overwritten anyway. Do patch away. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---