When researching an issue today I noticed ActionController::Base#render is originally protected, but then made public after including modules. I submitted ticket #7812 to fix it, and then thought I would check the other methods. I submitted ticket #7813 to fix other inconsistencies. Due to moving methods and whitespace changes from indenting, this patch will become more difficult to apply the longer it ages. Could somebody from the core team take a look (and maybe somebody not from the core team verify the patch)? Thanks. Methods changing visibility in ActionController::Base: render, process_cleanup, perform_action, assign_shortcuts, reset_session Methods changing visibility in ActiveRecord::Base: create, update, create_or_update, initialize http://dev.rubyonrails.org/ticket/7812 http://dev.rubyonrails.org/ticket/7813 Thanks, Dan Manges --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
It might be easier to change alias_method_chain to ensure that the new methods have the same public/private/protected status as the original one. Or is that not desirable? -Jonathan. On 3/13/07, Dan Manges <daniel.manges@gmail.com> wrote:> > > When researching an issue today I noticed > ActionController::Base#render is originally protected, but then made > public after including modules. I submitted ticket #7812 to fix it, > and then thought I would check the other methods. I submitted ticket > #7813 to fix other inconsistencies. > > Due to moving methods and whitespace changes from indenting, this > patch will become more difficult to apply the longer it ages. Could > somebody from the core team take a look (and maybe somebody not from > the core team verify the patch)? Thanks. > > Methods changing visibility in ActionController::Base: render, > process_cleanup, perform_action, assign_shortcuts, reset_session > > Methods changing visibility in ActiveRecord::Base: create, update, > create_or_update, initialize > > http://dev.rubyonrails.org/ticket/7812 > http://dev.rubyonrails.org/ticket/7813 > > Thanks, > Dan Manges > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 3/12/07, Jonathan Viney <jonathan.viney@gmail.com> wrote:> It might be easier to change alias_method_chain to ensure that the new > methods have the same public/private/protected status as the original one. > Or is that not desirable?Sounds like a good idea. In any case, I think it''s good practice to be consistent, so the patch is applied. jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---