Rails core - Feb 2007 - Nested with_scope and :joins

Hi,

I''ve been trying to DRY up my models in my current Rails project by
adding a dash of the very useful with_scope. However, I quickly
realized that when nesting with_scopes the outermost :joins are
forgotten. This somewhat limits the extent to which I can exploit the
use of with_scope.

Is there any way to preserve :joins through a nested with_scope stack?

Also, I''ve noticed that when extending a has_many :through association
with a find(:all, :joins => ...) the :through SQL join is forgotten
and causes a SQL syntax error. I think that this may be related to the
with_scope :joins problem.

Perhaps someone can shed some light on the reasoning behind this
situation.

Thanks,

Josh.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 2/24/07, Josh Bassett <josh.bassett@gmail.com>
wrote:
>
> Is there any way to preserve :joins through a nested with_scope stack?
>
> Perhaps someone can shed some light on the reasoning behind this
> situation.

Danger, danger! with_scope considered harmful. with_scope is not a generic,
do-it-all SQL combiner. It was only implemented to allow chaining foreign
keys conditions between associations:
  invoice.lineitems.find(1) == Lineitem.with_scope(:find => { :conditions
=>
[''invoice_id = ?'', invoice_id] }) { Lineitem.find(1) }

Please combine your conditions and joins explicitly if possible.

jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---