http://dev.rubyonrails.org/ticket/7114 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I should provide a little more info I suppose. The Duration class that makes 1.year.ago and friends accurate broke the tests for DateHelper, since the tests depended on the values generated by 1.year etc to be wrong. The patch adjusts the ranges of the minutes that map to which strings, rather than changing the tests to use to_f on the results of 1.year etc. If the latter approach is preferred, I''ll whip up another patch for it. On Jan 16, 9:28 pm, "eventualbuddha" <brian.dono...@gmail.com> wrote:> http://dev.rubyonrails.org/ticket/7114--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 1/16/07, eventualbuddha <brian.donovan@gmail.com> wrote:> > I should provide a little more info I suppose. The Duration class that > makes 1.year.ago and friends accurate broke the tests for DateHelper, > since the tests depended on the values generated by 1.year etc to be > wrong. The patch adjusts the ranges of the minutes that map to which > strings, rather than changing the tests to use to_f on the results of > 1.year etc. If the latter approach is preferred, I''ll whip up another > patch for it.Applied. Thanks for staying on top of that. -- Rick Olson http://weblog.techno-weenie.net http://mephistoblog.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---