Hi all I''ve provided another patch for resource_feeder, making the rss 2.0 generation a bit more robust and flexible. It now includes some pubDate for the feed and not just the items, for example, which is probably something that should be there by default. I''ve also added some docs for the rss piece and a little bit better error handling to make it more user friendly. This patch also includes an older patch that hasn''t been committed that changed the calls to SimplyHelpful use the latest method names - so if nothing else, that should definitely be committed :). As it stands right now, if you checkout the latest SimplyHelpful and ResourceFeeder, ResourceFeeder will just not work since its out of date with the latest SimplyHelpful api. If this looks good, I''ll probably make the same type of changes to the atom piece. Tests are included, and feedback welcome. thanks, Rob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Josh Knowles
2006-Dec-11 17:17 UTC
Re: more love for resource_feeder, feedback appreciated
On 12/11/06, Rob Sanheim <rsanheim@gmail.com> wrote:> This patch also includes an older patch that hasn''t been committed > that changed the calls to SimplyHelpful use the latest method names - > so if nothing else, that should definitely be committed :). As it > stands right now, if you checkout the latest SimplyHelpful and > ResourceFeeder, ResourceFeeder will just not work since its out of > date with the latest SimplyHelpful api. >+1 for applying this. I ran into the problem last night of ResourceFeeder not working with the latest SimplyHelpful. Josh -- Josh Knowles joshknowles@gmail.com http://joshknowles.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Josh Knowles wrote:> > > On 12/11/06, *Rob Sanheim* <rsanheim@gmail.com > <mailto:rsanheim@gmail.com>> wrote: > > This patch also includes an older patch that hasn''t been committed > that changed the calls to SimplyHelpful use the latest method names - > so if nothing else, that should definitely be committed :). As it > stands right now, if you checkout the latest SimplyHelpful and > ResourceFeeder, ResourceFeeder will just not work since its out of > date with the latest SimplyHelpful api. > > > +1 for applying this. I ran into the problem last night of > ResourceFeeder not working with the latest SimplyHelpful. > > Josh > > -- > Josh Knowles > joshknowles@gmail.com <mailto:joshknowles@gmail.com> > http://joshknowles.com > >+1. Also I wonder if anyone else has had problems with Simply Helpful and STI classes (it essentially requires them to have their own controller). --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 12/11/06, Rob Sanheim <rsanheim@gmail.com> wrote:> Hi all > > I''ve provided another patch for resource_feeder, making the rss 2.0 > generation a bit more robust and flexible. It now includes some > pubDate for the feed and not just the items, for example, which is > probably something that should be there by default. I''ve also added > some docs for the rss piece and a little bit better error handling to > make it more user friendly. > > This patch also includes an older patch that hasn''t been committed > that changed the calls to SimplyHelpful use the latest method names - > so if nothing else, that should definitely be committed :). As it > stands right now, if you checkout the latest SimplyHelpful and > ResourceFeeder, ResourceFeeder will just not work since its out of > date with the latest SimplyHelpful api. > > If this looks good, I''ll probably make the same type of changes to the > atom piece. Tests are included, and feedback welcome. > > thanks, > Rob >+bumping for someone in core to take a look. Any help? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
++++20 I just put in a patch for this. I should have searched first. Doh! But this has broken most of our projects here at Unspace. Boooo! Please help! -hampton. On 12/13/06, Rob Sanheim <rsanheim@gmail.com> wrote:> > On 12/11/06, Rob Sanheim <rsanheim@gmail.com> wrote: > > Hi all > > > > I''ve provided another patch for resource_feeder, making the rss 2.0 > > generation a bit more robust and flexible. It now includes some > > pubDate for the feed and not just the items, for example, which is > > probably something that should be there by default. I''ve also added > > some docs for the rss piece and a little bit better error handling to > > make it more user friendly. > > > > This patch also includes an older patch that hasn''t been committed > > that changed the calls to SimplyHelpful use the latest method names - > > so if nothing else, that should definitely be committed :). As it > > stands right now, if you checkout the latest SimplyHelpful and > > ResourceFeeder, ResourceFeeder will just not work since its out of > > date with the latest SimplyHelpful api. > > > > If this looks good, I''ll probably make the same type of changes to the > > atom piece. Tests are included, and feedback welcome. > > > > thanks, > > Rob > > > > > +bumping for someone in core to take a look. Any help? > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
bumping again -- could anyone take a look at the patch and consider applying? I''d like to do more work to resource_feeder (as it doesn''t fully comply w/ atom 1.0), but I''d like to see this applied first. http://dev.rubyonrails.org/ticket/6816 - rob On 12/14/06, Hampton <hcatlin@gmail.com> wrote:> > ++++20 > > I just put in a patch for this. I should have searched first. Doh! > > But this has broken most of our projects here at Unspace. Boooo! > > Please help! > > -hampton. > > On 12/13/06, Rob Sanheim <rsanheim@gmail.com> wrote: > > > > On 12/11/06, Rob Sanheim <rsanheim@gmail.com> wrote: > > > Hi all > > > > > > I''ve provided another patch for resource_feeder, making the rss 2.0 > > > generation a bit more robust and flexible. It now includes some > > > pubDate for the feed and not just the items, for example, which is > > > probably something that should be there by default. I''ve also added > > > some docs for the rss piece and a little bit better error handling to > > > make it more user friendly. > > > > > > This patch also includes an older patch that hasn''t been committed > > > that changed the calls to SimplyHelpful use the latest method names - > > > so if nothing else, that should definitely be committed :). As it > > > stands right now, if you checkout the latest SimplyHelpful and > > > ResourceFeeder, ResourceFeeder will just not work since its out of > > > date with the latest SimplyHelpful api. > > > > > > If this looks good, I''ll probably make the same type of changes to the > > > atom piece. Tests are included, and feedback welcome. > > > > > > thanks, > > > Rob > > > > > > > > > +bumping for someone in core to take a look. Any help? > > > > > > > > > > >-- http://www.robsanheim.com http://www.seekingalpha.com http://www.ajaxian.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Dr. Ernie Prabhakar
2007-Jan-25 00:12 UTC
Re: more love for resource_feeder, feedback appreciated
Hi Rob, On Jan 24, 2007, at 9:25 AM, Rob Sanheim wrote:> bumping again -- could anyone take a look at the patch and consider > applying? I''d like to do more work to resource_feeder (as it doesn''t > fully comply w/ atom 1.0), but I''d like to see this applied first. > > http://dev.rubyonrails.org/ticket/6816DHH recently challenged me (or anyone) to implement APP on top of Rails 1.2. Would it be possible to leverage resource_feeder in doing that? -- Ernie P. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> bumping again -- could anyone take a look at the patch and consider > applying? I''d like to do more work to resource_feeder (as it doesn''t > fully comply w/ atom 1.0), but I''d like to see this applied first.It''s not applying cleanly any more: $ pap http://dev.rubyonrails.org/attachment/ticket/6816/resource_feeder_patch.diff?format=txt patching file test/rss_feed_test.rb patching file lib/resource_feeder/atom.rb Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file lib/resource_feeder/atom.rb.rej patching file lib/resource_feeder/rss.rb Hunk #2 FAILED at 67. 1 out of 5 hunks FAILED -- saving rejects to file lib/resource_feeder/rss.rb.rej patching file README Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file README.rej Could you fix it up? I''ll apply then. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---